MyBB Community Forums
[Pushed] Column Modification Issues - Printable Version

+- MyBB Community Forums (https://community.mybb.com)
+-- Forum: Development (https://community.mybb.com/forum-161.html)
+--- Forum: MyBB 1.8 Development (https://community.mybb.com/forum-165.html)
+---- Forum: 1.8 Bugs and Issues (https://community.mybb.com/forum-157.html)
+----- Forum: Pushed (https://community.mybb.com/forum-183.html)
+----- Thread: [Pushed] Column Modification Issues (/thread-231702.html)



Column Modification Issues - dragonexpert - 2021-03-14

Currently the code for $db->add_column and $db->modify_column do not actually check if the column type or definition are valid for the database engine that is used.  SQLite doesn't have VARBINARY, but instead is called BLOB as one example.  I propose creating another method in the database classes that actually validates what column types and attributes are available.   If the column type is not supported, then it returns the equivalent for that database engine.  Any attributes that are not supported such as UNSIGNED are stripped out from the definition as well.

The reason for this suggestion is that many plugins on the extend site only support MySQLi.  This leaves users that don't have that available or who prefer to use a different database engine a lot less options and would generally need to hire a developer to make changes to make the plugin work.


RE: Column Modification Issues - effone - 2021-04-01

Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/4350

Thanks for contributing to MyBB!

Regards,
The MyBB Group