[Pushed] Post edited by Admin requires approval again

[Dr_The_One]

I don't know whether MyBB script is like this or have I to modify something.

Steps:
1. I kept moderation tick for the post of a member on new post and also after editing.
2. Member created a thread so it requires approval.
3. Admin approve it via post approval moderation tool from the thread.
4. So, the thread is approved.
5. Now, Admin edit that member's thread then also that thread goes for approval. 

Point 5 is weird to me. 
As per my thinking, the post edited by the admin MUST not go for approval again.
Is anything need to be modified in permission to remove again required approval after editing or it is not possible to do in MyBB script.?

Hope you understand.
Thank you.

[Matt]

It shouldn't do that if the user is a moderator, and admins should be moderators.

If you go to ACP > Users & Groups > Groups > Administrators > at the bottom there's the option "Yes, users of this group are super moderators", is this selected?

[Dr_The_One]

Yes, the administrator group is already selected as a super moderator. and admin also is a moderator in the selected forum in which that thread is created.

[Matt]

Is the post inside a forum where users can only see their own threads?

[Dr_The_One]

Is the post inside a forum where users can only see their own threads?

Yes, I had kept that setting for the forum.

After you mention the above point, I deselect user can only see their own threads, but still it requires approval after edit by admin.

---

In ACP > Users & Groups > Groups > Administrators > Forum and Posts > all 4 Moderation option also ticked .

---

2nd Issue: Quick edit does not require approval if the thread creator or admin edit 1st post of the thread but it required approval if edited through full edit.

[Matt]

Hm, I think that would actually be classed as a bug to be honest.

This is from inc/datahandlers/post.php:

if(isset($post['uid']))
{
	$uid = $post['uid'];
}
else
{
	$uid = 0;
}

$forum = get_forum($post['fid']);
$forumpermissions = forum_permissions($post['fid'], $uid);

// Decide on the visibility of this post.
$ismod = is_moderator($post['fid'], "", $uid);

// Keep visibility for unapproved and deleted posts
if($existing_post['visible'] == 0)
{
	$visible = 0;
}
elseif($existing_post['visible'] == -1)
{
	$visible = -1;
}
elseif($forumpermissions['mod_edit_posts'] == 1 && !$ismod)
{
	$visible = 0;
	require_once MYBB_ROOT."inc/class_moderation.php";
	$moderation = new Moderation;
	$moderation->unapprove_posts(array($post['pid']));
}
else
{
	$visible = 1;
}

Where it checks mod_edit_posts and !$ismod, $ismod is whether the post author is a moderator. I would have thought this should be if the user is a moderator (or maybe both). It's been like this for 8 years though so not been noticed before.

[Matt]

Moved to the bug report forum to see if others agree as I don't think this is correct. If it wants to check whether the post author is a moderator then that's fine, but I think it should check whether the user editing the post is a moderator too. I guess it's like this as we can't tell if the post went through approval previously, but if a moderator is editing it, it shouldn't matter.

[Dr_The_One]

I put the post author in the moderator for that forum in which the thread was created then the thread does not require approval for whoever(admin or post author) editing the post.

BUT

if I remove the post author from the moderator of that forum then the thread require approval for whoever(admin or post author) editing the post.

Also, look for 2nd Issue: Quick edit does not require approval if the thread creator or admin edit 1st post of the thread but it required approval if edited through full edit.

Thank you.

[Ben]

Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/4623

Thanks for contributing to MyBB!

Regards,
The MyBB Group