Seems like you are doing only one query per page, by at a first glance is better than many other methods used in plugins. Even I do a query per username in my newpoints plugin, which is nonsense.
https://github.com/Sama34/Newpoints-Buy-...t.php#L342
I would rather recommend the use of the pre_output_page hook if possible to make a mass replace of all usernames with a less heavy query since you are getting all users with a custom username instead of just the ones displayed in the page.
pre_output_page has its limitations, for example, in modals windows where username may be displayed so it could be a tricky path that could probably require frequent updates to work around found issues like this.
Anyways, just wanted to give my input, it is yet seems better that anything currently out there, cheers!
https://github.com/Sama34/Newpoints-Buy-...t.php#L342
I would rather recommend the use of the pre_output_page hook if possible to make a mass replace of all usernames with a less heavy query since you are getting all users with a custom username instead of just the ones displayed in the page.
pre_output_page has its limitations, for example, in modals windows where username may be displayed so it could be a tricky path that could probably require frequent updates to work around found issues like this.
Anyways, just wanted to give my input, it is yet seems better that anything currently out there, cheers!
Soporte en Español
![[Image: signature.png]](https://camo.mybb.com/073de152385cf9dc8559ca20ba567646bc9c96c5/68747470733a2f2f6f6d6172672e6d652f63616368652f696d616765732f7369676e61747572652e706e67)
Discord at
Discord at
omar.gonzalez (Omar G.#6117); Telegram at @omarugc;