(2012-12-24, 04:27 PM)euantor Wrote: One thing I have noticed after browsing your code is how the _is_installed() function works. Users can clear the admin log via the ACP so your current check could easily return false even when it is installed.
I never considered that.
Would it be better to use this?
function mention_is_installed ()
{
global $cache, $plugins;
$pluginlist = $cache->read("plugins");
return in_array('mention', $pluginlist['active']);
}
EDIT:
No, that doesn't work correctly. I will keep trying.
(2012-12-24, 04:27 PM)euantor Wrote: The way you update user settings could also cause a timeout on boards with large amounts of users too. I still need to find a better way of handling settings so that's kind of my fault.
What is it that I am doing wrong?
Please let me know if there is a better way and I will implement the changes.
Thanks for all you help
[retired]