2020-11-12, 09:35 PM
Hey Omar,
Thanks for checking out the plugin and testing on your 100k-post board. Glad it's working for you so far.
Re the flaw you point out, I'm confused for a couple of reasons.
Firstly, I am confused because (1) the plugin deliberately sets the "keywords" search array entry to an empty string (on line 2685 of inc/plugins/linktools.php), such that the "highlight" query parameter should never be added to any results URLs for searches intercepted by the plugin (given lines 154-165 of search.php) but (2) the URL you use as an example *should* be intercepted by the plugin. Is it possible that you had temporarily deactivated the plugin when testing that search?
Before getting to the second bit of confusion, I think you've misdiagnosed the cause of the 404 error for the URL you provide: as best I can tell, the problem is that the ampersand should be a question mark. So, my second confusion is that I am not sure how this error has occurred, because it looks like you have core SEO enabled, and line 159 of search.php should correctly ensure a question mark rather than an ampersand.
Would be interested to know what you make of all that...
Thanks for checking out the plugin and testing on your 100k-post board. Glad it's working for you so far.
Re the flaw you point out, I'm confused for a couple of reasons.
Firstly, I am confused because (1) the plugin deliberately sets the "keywords" search array entry to an empty string (on line 2685 of inc/plugins/linktools.php), such that the "highlight" query parameter should never be added to any results URLs for searches intercepted by the plugin (given lines 154-165 of search.php) but (2) the URL you use as an example *should* be intercepted by the plugin. Is it possible that you had temporarily deactivated the plugin when testing that search?
Before getting to the second bit of confusion, I think you've misdiagnosed the cause of the 404 error for the URL you provide: as best I can tell, the problem is that the ampersand should be a question mark. So, my second confusion is that I am not sure how this error has occurred, because it looks like you have core SEO enabled, and line 159 of search.php should correctly ensure a question mark rather than an ampersand.
Would be interested to know what you make of all that...