[Rejected] Rewrite of the login rewrite
#1
Yeah I know, the login has been rewritten for 1.8, but
  • login methods email / email + username where not implemented correctly (I fixed this, but it's quite dirty due to the next point in my list)
  • there are up to 4 database queries depending on the case fetching nearly the same data (failed login count, username, password, updating failed login count, fetching failed login count)
  • Display number of failed login settings does not work (setting to yes does not show the remaining login attempts)
  • you have an unlimited number of guesses for the Admin CP Pin
  • The failed login count in the database is only used for the captcha setting, not for blocking the entire login
  • When a captcha is required the login page does not show the captcha the first time it is required
I can create a thread per issue, but I think dealing with those problems in one step might be easier, because it would probably be a rewrite and dealing with one issue at a time might result in really weird code...
You found my signature? Well done : - )
Reply


Messages In This Thread
Rewrite of the login rewrite - by Nik101010 - 2014-09-04, 11:38 AM
RE: Rewrite of the login rewrite - by Eldenroot - 2014-09-05, 11:06 AM
RE: Rewrite of the login rewrite - by Destroy666 - 2014-11-17, 10:03 PM
RE: Rewrite of the login rewrite - by Nik101010 - 2014-11-17, 10:11 PM
RE: Rewrite of the login rewrite - by Jones H - 2015-06-25, 09:36 AM
RE: Rewrite of the login rewrite - by Destroy666 - 2015-06-25, 09:47 AM
RE: Rewrite of the login rewrite - by Nik101010 - 2015-06-25, 10:08 AM
RE: Rewrite of the login rewrite - by Jones H - 2015-07-02, 08:39 AM
RE: Rewrite of the login rewrite - by Destroy666 - 2015-07-02, 03:02 PM

Forum Jump:


Users browsing this thread: 1 Guest(s)