2015-07-02, 03:02 PM
(This post was last modified: 2015-07-02, 04:18 PM by Destroy666.)
(2015-07-02, 08:39 AM)JonesĀ H Wrote: So the only issue left is the loginattempts check?
Noone said that, so not sure what you mean (unless you can't reproduce the rest yourself).
The 4 issues I quoted above are most likely still present, I can definitely confirm the 1st (some queries look like redundan duplicates, not sure if we can/should optimise them) and 2nd (I can't see the number of failed/remaining tries anywhere), the 4th is still there too IIRC (there is sometimes a captcha error without showing the captcha first).
The 3rd is connected with the internal discussion indeed, I'm not sure how exactly it works, the code is quite messy and spread among loginhandler, member.php login action and function file(s).