Discuss: MyBB 1.2.7 Released - Security & Maintenance Release
#29
The upgrade was a breeze Chris, and thanks to you and all of the progammers who participated in it. Smile

Only one suggestion.. And there's always plenty of them. Toungue

I use two rows of code-buttons in the editor, and again I had to split some params in editor.js; plus adding all of the other stuff.

Why not change the heightXwidth browser type to "subtract2" and "subtract3"

Makes it so much easier for those wanting to add extra code-buttons. Wink
		// Set the height of the area
		subtract = subtract2 = 0;
		if(MyBB.browser != "ie" || (MyBB.browser == "ie" && MyBB.useragent.indexOf('msie 7.') != -1))
		{
			subtract = subtract2 = 35;
		}
		areaContainer.style.height = parseInt(editor.style.height)-parseInt(toolBar.style.height)-parseInt(toolbar2.style.height)-subtract+"px";

		// Set the width of the area
		subtract = subtract3 = 0;
		if(MyBB.browser != "ie" || (MyBB.browser == "ie" && MyBB.useragent.indexOf('msie 7.') != -1))
		{
			subtract = subtract3 = 8;
		}

		areaContainer.style.width = parseInt(editor.style.width)-subtract3+"px";

I had done this for FF in v1.2.6, but v1.2.7 seems to have fixed the mozilla problem too. Smile

And the default would be height = 8, not 35 Lol!..

Great Job! Toungue


Messages In This Thread
RE: Discuss: MyBB 1.2.7 Released - Security & Maintenance Release - by Lopalong - 2007-05-16, 10:33 AM

Forum Jump:


Users browsing this thread: 1 Guest(s)