[Pushed] SMTP authentication problem with DIGEST-MD5 or CRAM-MD5

[memeber1]

hey all,

As I am trying to set up a new SMTP server and  I've encoutered this weird problem where I can not authetificate.
I get this error message saying "The SMTP server does not support any of the AUTH methods that MyBB supports". Doesn't matter if I use ssl, tls or plain authetication, it just won't work.

So I poked around in the auth() function of smtp.php and I found out, that my SMTP server is returning these authentication methods DIGEST-MD5, CRAM-MD5 but the function is only checking for LOGIN or PLAIN methods. (see lines 357 and 381)

If I change these lines:

if(in_array("LOGIN", $auth_methods)) 

to:

if(in_array("DIGEST-MD5", $auth_methods))

,doesn't matter which line I change to DIGEST-MD5 or CRAM-MD5, the email gets sent.

Now that is cool that I can send emails by changing these values, but:

1. I might won't be the only once facing this issue
   
2. I am not sure, if the code bellow the "if" is the right way to use CRAM-MD5 or DIGEST-MD5
   

Thank you for the time devs! I think this issue should be solved in the next release, or just point me into the right direction .

Have a nice day!