2021-02-12, 08:15 AM
(This post was last modified: 2021-02-12, 02:59 PM by Laird. Edited 5 times in total.)
(2021-02-12, 08:08 AM)Omar G. Wrote: Hi, the update didn't work for me for some reason (no previews are displayed although apparently they are rebuilt successfully), I will certainly deep into the issue but I lack time ATM.
Hmm. That's not good. The first thing to do would probably be to make sure that you have the latest version of the code, as there was a bug which I fixed recently which was inhibiting previews in some situations.
(2021-02-12, 08:08 AM)Omar G. Wrote: What I noticed, is that you include the global.php file in the ACP module page. I think this should be discouraged and reviewed by you.Thanks for the heads-up. I've removed it in my working code.
(2021-02-12, 08:08 AM)Omar G. Wrote: Edit: About PDF rendering, I think this feature isn't necessary, if it is a PDF then don't render a preview. Most browsers already handle PDFs like web pages.
Thanks for your advice. I would like though for the plugin to at least support this sort of scenario even if in practice it isn't used. Am working on the code as we speak so you should soon be able to see how I've added this support.
Have now added this support, and with it support for a Plain Text helper (where Content-Type is "text/plain", regardless of the form of the link).
In addition, have added a YouTube video helper.
All pushed to the GitHub repo.
Oh, and just a note: those two new helpers won't be auto-enabled, even via the deactivate-copy-files-reactivate upgrade method: you need to go to the Link Helpers module under "Configuration" in the ACP and check their "Template installed?" and "Enabled?" boxes then click "Update Link Helpers".
Finally (though it should have been first): thank you very much for taking some of your precious time to test this plugin out. I really appreciate it.