MyBB Community Forums › Community Archive › Archived Forums › Archived Development and Support › MyBB 1.2 Series › MyBB 1.2 General Support v
PM Popup won't show

Threaded Mode
PM Popup won't show
Ryan Gordon Offline

Former Staff
Posts: 16,264
Threads: 579
Joined: Oct 2005
Reputation: 39
#21
2006-12-13, 09:28 PM
clear your cache and try again.
Website Find
Paul124897 Offline
Posts: 12
Threads: 1
Joined: Dec 2006
Reputation: 0
#22
2006-12-13, 10:56 PM
Tikitiki Wrote:clear your cache and try again.

I have done, it's still the same :/
Find
Christian Offline

Former Staff
Posts: 1,328
Threads: 17
Joined: Oct 2005
Reputation: 6
#23
2006-12-14, 12:26 AM
Hmm.. Can you send me another PM please.
[Need Smilies? Get Me Smileys!] 
Find
Paul124897 Offline
Posts: 12
Threads: 1
Joined: Dec 2006
Reputation: 0
#24
2006-12-14, 06:11 PM
Christian Wrote:Hmm.. Can you send me another PM please.

Sure, all done.
Find
Christian Offline

Former Staff
Posts: 1,328
Threads: 17
Joined: Oct 2005
Reputation: 6
#25
2006-12-15, 01:25 AM
Hmm. I just applied my code- with CraKteR's bug fix -on my test board and it works. This is weird. Confused
[Need Smilies? Get Me Smileys!] 
Find
Paul124897 Offline
Posts: 12
Threads: 1
Joined: Dec 2006
Reputation: 0
#26
2006-12-15, 01:51 AM
Christian Wrote:Hmm. I just applied my code- with CraKteR's bug fix -on my test board and it works. This is weird. Confused

Shall I just reinstall the whole thing?
Find
Christian Offline

Former Staff
Posts: 1,328
Threads: 17
Joined: Oct 2005
Reputation: 6
#27
2006-12-15, 02:07 AM (This post was last modified: 2006-12-15, 02:44 AM by Christian.)
I don't think that's necessary, the problem with with this Image resizer plugin...
[Need Smilies? Get Me Smileys!] 
Find
Ryan Gordon Offline

Former Staff
Posts: 16,264
Threads: 579
Joined: Oct 2005
Reputation: 39
#28
2006-12-15, 02:21 AM
I think for such a small problem, that it really isn't necessary to reinstall the whole thing. Do you have javascript enabled?

And if I understood correctly, this will work differently in 1.4
Website Find
Christian Offline

Former Staff
Posts: 1,328
Threads: 17
Joined: Oct 2005
Reputation: 6
#29
2006-12-15, 04:02 AM (This post was last modified: 2006-12-15, 03:43 PM by Ryan Gordon.)
As established already, this is a bug or limitation of the Image resizer plugin. Here is a quick and dirty solution I came up with; It appears to work. Remember to revert your functions.php with a fresh copy.

In the plugin file(inc/plugins/imageresizer.php).

Find:
function imageresizer_page($page)
{
	global $mybb;
	// var_dump($mybb);
	if ($mybb->settings['image_resizer_active'] == "yes")
	{
		$page = str_replace('</head>', imageresizer_javascript().'</head>', $page);
		$page = preg_replace('#<body(.*?)>#', '<body onload="resize_images()"$1>', $page);
	}
	
	return $page;
}

Replace with:
function imageresizer_page($page)
{
	global $mybb, $loadpmpopup;
	// var_dump($mybb);
	if ($mybb->settings['image_resizer_active'] == "yes")
	{
		$page = str_replace('</head>', imageresizer_javascript().'</head>', $page);
		$page = preg_replace('#<body(.*?)>#', '<body onload="resize_images()"$1>', $page);
		// Fix for PM popup.
		if($loadpmpopup)
		{
			if(my_substr($_SERVER['PHP_SELF'], -strlen("private.php")) != "private.php")
			{
				$page = str_replace(" onload=\"Javascript:MyBB.newPM()\"", "", $page);
				$page = str_replace("<body onload=\"resize_images()\"", "<body onload=\"resize_images(); Javascript:MyBB.newPM()\"", $page);
			}
		}
	}
	
	return $page;
}

Christian
[Need Smilies? Get Me Smileys!] 
Find
Paul124897 Offline
Posts: 12
Threads: 1
Joined: Dec 2006
Reputation: 0
#30
2006-12-15, 02:54 PM
Christian Wrote:As established already, this is a bug or limitation of the Image resizer plugin. Here is a quick and dirty solution I came up with; It appears to work. Remember to revert your functions.php with a fresh copy.

In the plugin file(inc/plugins/imageresizer.php).

Find:
function imageresizer_page($page)
{
	global $mybb;
	// var_dump($mybb);
	if ($mybb->settings['image_resizer_active'] == "yes")
	{
		$page = str_replace('</head>', imageresizer_javascript().'</head>', $page);
		$page = preg_replace('#<body(.*?)>#', '<body onload="resize_images()"$1>', $page);
	}
	
	return $page;
}

Replace with:
function imageresizer_page($page)
{
	global $mybb, $loadpmpopup;
	// var_dump($mybb);
	if ($mybb->settings['image_resizer_active'] == "yes")
	{
		$page = str_replace('</head>', imageresizer_javascript().'</head>', $page);
		$page = preg_replace('#<body(.*?)>#', '<body onload="resize_images()"$1>', $page);
		// Fix for PM popup.
		if($loadpmpopup)
		{
			if(my_substr($_SERVER['PHP_SELF'], -strlen("private.php")) != "private.php")
			{
				$page = str_replace(" onload=\"Javascript:MyBB.newPM()\"", "", $page);
				$page = str_replace("<body onload=\"resize_images()\"", "<body onload=\"resize_images(); Javascript:MyBB.newPM()\"", $page);
			}
		}
	}
	
	return $page;

Christian

Thanks, works great now!

By the way, you missed a } after return $page Wink
Find


Forum Jump:


Users browsing this thread: 1 Guest(s)