[Pushed] Update Attachment Makes Orphaned Attachment

[Jabberwock]

Updating an already existing attachment(basically replacing) will replace the file that was previously put but won't delete the old one as it would have normally done.

How to reproduce:

1. make a thread with an attachment
2. click on full edit
3. select another attachment
4. click on Update Attachment
5. go in ACP to Attachments -> Orphaned Attachments, in there you would be able to see that it made the previous attachment as an orphaned one, meaning it didn't delete it as it should have been done

Can anyone confirm this?

[Starpaul20]

Yes, I can confirm this.

[Starpaul20]

Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/740

Thanks for contributing to MyBB!

Regards,
The MyBB Group