Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
1.8 Small improvements: Make style of editor textarea dependent with theme of editor
#1
Instead of code below:

opt_editor = {
	plugins: "bbcode",
	style: "{$mybb->asset_url}/jscripts/sceditor/jquery.sceditor.mybb.css",
	rtl: {$lang->settings['rtl']},

Better something this:

opt_editor = {
	plugins: "bbcode",
	style: "{$mybb->asset_url}/jscripts/sceditor/textarea_styles/jquery.sceditor.{$theme['editortheme']}",
	rtl: {$lang->settings['rtl']},

Why of this?
jquery.sceditor.mybb.css is used to style WYSIWYG mode element of textarea... Quote tag, Code tag etc...

Currently jquery.sceditor.mybb.css matches with style of quote tag, code tag etc... with default theme of mybb 1.8.

http://i.imgur.com/gLITrSY.png

But other themes of mybb 1.8 may have different style to quote tag, code tag etc... So theme creator may want to combine style of quote tag, code tag of editor with your theme...

modification should be something: https://github.com/martec/mybb/compare/m...e?expand=1



What documentation of sceditor said about style option:

[Image: qT7QX12.png]

http://www.sceditor.com/documentation/options/
Reply
#2
+1 - why not? Small improvement but it can be a huge help for theme creators
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#3
(2014-08-01, 12:52 PM)Eldenroot Wrote: +1 - why not? Small improvement but it can be a huge help for theme creators

is now too late...
I should have suggested earlier...
http://community.mybb.com/thread-156683-...pid1089058
Reply
#4
It can still be implemented in 1.8.1. Smile
Reply
#5
I agree... mybb 1.8.1 will be there quite soon after 1.8 - I think there will be a lot of bugs which will be found after official release -> more users = more testing -> more bugs reports

You can discuss this with mybb team and make a PR maybe
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#6
now that 1.8.0 already released, possible push this ?
Reply
#7
I want to see it on MyBB 1.8.1, nice idea!
Do you want the theme of Abstractos.net? ( http://abstractos.net/ )

I trade it for steam cs:go keys, add me: http://steamcommunity.com/id/MyOwnDreamer/
Reply
#8
Sure.
Reply
#9
(2014-09-10, 06:26 AM)Omar G. Wrote: Sure.

so i could push PR?
Reply
#10
I meant that I agree with the suggestion actually.

But bow I see some issues, IIRC in 1.6 it worked like this. Also how are you going to handle the editor if used in AC?.
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)