MyBB Community Forums › Development › MyBB 1.8 Development › 1.8 Bugs and Issues › Pushed v
[Pushed] Add to buddy list bug

Threaded Mode
[Pushed] Add to buddy list bug
mikeh Offline
Posts: 248
Threads: 39
Joined: Jul 2014
Reputation: 10
#1
2014-08-15, 09:39 PM
If you send an user a buddy request there is still an option to send a buddy request until the user responds to it (add/decline/block).
Find
Reply
Eldenroot Offline

Contributor
Posts: 3,317
Threads: 192
Joined: May 2014
Reputation: 147
#2
2014-08-16, 10:11 AM
There should be a message that you have already sent a friend request to this user
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Website Find
Reply
Diogo Parrinha Offline

Former Staff
Posts: 6,835
Threads: 303
Joined: Jun 2007
Reputation: 94
#3
2014-08-16, 06:48 PM
Hmmm I doubt that happens. I remember adding an error message in case you try to re-send the request. Can someone confirm this?
All my plugins are available for free at MyBB Extend and on my GitHub. MyBB-Plugins.com has been closed and none of my plugins are officially maintained or supported.
Website Find
Reply
Eldenroot Offline

Contributor
Posts: 3,317
Threads: 192
Joined: May 2014
Reputation: 147
#4
2014-08-16, 06:52 PM
@Pirata Nervo - please reject this. There is a message on the right top when you wanna send another request to same user
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Website Find
Reply
Diogo Parrinha Offline

Former Staff
Posts: 6,835
Threads: 303
Joined: Jun 2007
Reputation: 94
#5
2014-08-16, 06:53 PM
Thanks for confirming what I thought Smile Rejected.
All my plugins are available for free at MyBB Extend and on my GitHub. MyBB-Plugins.com has been closed and none of my plugins are officially maintained or supported.
Website Find
Reply
mikeh Offline
Posts: 248
Threads: 39
Joined: Jul 2014
Reputation: 10
#6
2014-08-16, 06:56 PM
(2014-08-16, 06:48 PM)Pirata Nervo Wrote: Hmmm I doubt that happens. I remember adding an error message in case you try to re-send the request. Can someone confirm this?

(2014-08-16, 06:52 PM)Eldenroot Wrote: @Pirata Nervo - please reject this. There is a message on the right top when you wanna send another request to same user

I just tested this with Eldenroot's profile and the "Add to Buddy List" button is still on his profile. I say that this is a bug because 1.8 was supposed to hide things that were invalid (regular users can no longer see the Delete button in full edit, etc.). Also the confirmation page needs to be changed. It says, "The selected users have been added to your buddy list." when in fact they're not. They will need to accept your buddy request first.
Find
Reply
Eldenroot Offline

Contributor
Posts: 3,317
Threads: 192
Joined: May 2014
Reputation: 147
#7
2014-08-16, 07:02 PM
Please send a screenshot
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Website Find
Reply
mikeh Offline
Posts: 248
Threads: 39
Joined: Jul 2014
Reputation: 10
#8
2014-08-16, 07:10 PM
(2014-08-16, 07:02 PM)Eldenroot Wrote: Please send a screenshot


Attached Files Thumbnail(s)
   
Find
Reply
Eldenroot Offline

Contributor
Posts: 3,317
Threads: 192
Joined: May 2014
Reputation: 147
#9
2014-08-16, 07:17 PM
Now I see - so you just wanna hide "Add to buddy list" button after you send a request, right? I was a little bit confused and your description was not good.

Anyway, there is a space for improving:
1) show different image instead of the button - something like: "Request has been sent" after you send a request
2) hide this button - it is not a good idea
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Website Find
Reply
mikeh Offline
Posts: 248
Threads: 39
Joined: Jul 2014
Reputation: 10
#10
2014-08-16, 07:20 PM
(2014-08-16, 07:17 PM)Eldenroot Wrote: Now I see - so you just wanna hide "Add to buddy list" button after you send a request, right? I was a little bit confused and your description was not good.

Anyway, there is a space for improving:
1) show different image instead of the button - something like: "Request has been sent" after you send a request
2) hide this button - it is not a good idea
#1 is the better choice
Find
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)