[For 1.8] Quick Advanced Editor 6.1.2 (Show sceditor in quick reply and quick edit)

[Leefish]

hi martec,

I am using the Quick Advanced Editor (6.1.1) and am hitting this firefox bug where the page jumps to the bottom in showthread. I read your post saying "here is the fix in 1.4.6" and have tried to apply it, but it does not seem to work.

Which file should we edit? The jquery.sceditor.min.js is heavily minified; I cannot figure out how to add the code in the fix in a good format. If I use unminified code then the size of the file triples and I don't want that either.

Is it possible for you to update the files for mybb and commit to github for 1.84 ?

[martec]

hi martec,

I am using the Quick Advanced Editor (6.1.1) and am hitting this firefox bug where the page jumps to the bottom in showthread. I read your post saying "here is the fix in 1.4.6" and have tried to apply it, but it does not seem to work.

Which file should we edit? The jquery.sceditor.min.js is heavily minified; I cannot figure out how to add the code in the fix in a good format. If I use unminified code then the size of the file triples and I don't want that either.

Is it possible for you to update the files for mybb and commit to github for 1.84 ?

you can use unminified file to add code, and after use some minifier tool as this http://refresh-sf.com/ to minifier file again to reduce size

[Leefish]

I did - and it did not work. I added the code to the sceditor file in the sceditorfolder.

This is the unminified code:  http://testfish.leefish.nl/jscripts/sced...or.edit.js

What am I doing wrong? Obviously I did rename it.

[martec]

I did - and it did not work. I added the code to the sceditor file in the sceditorfolder.

This is the unminified code:  http://testfish.leefish.nl/jscripts/sced...or.edit.js

What am I doing wrong? Obviously I did rename it.

sorry...
you need add code in https://github.com/samclarke/SCEditor/bl...ceditor.js in minifier tool you need put edited file (jquery.sceditor.js) + https://github.com/samclarke/SCEditor/bl.../bbcode.js (bbcode.js) ..
after
you rename to jquery.sceditor.bbcode.min.js and replace.
jquery.sceditor.bbcode.min.js = jquery.sceditor.js + bbcode.js

[Leefish]

I am sorry Martec, but I just cant get this to work. I did exactly what you said above and still the pagination jumps to the bottom in firefox.

I have the new file in the sceditor folder.

[martec]

I am sorry Martec, but I just cant get this to work. I did exactly what you said above and still the pagination jumps to the bottom in firefox.

I have the new file in the sceditor folder.

you edited correctly and cleaned cache?

in https://github.com/samclarke/SCEditor/bl...ceditor.js you need replace line 2612 to 2617 (total 6 lines to replace ) with "$wysiwygBody.blur();" (without quotes).

after you put in minifier tool with bbcode.js
and rename to jquery.sceditor.bbcode.min.js and upload to jscripts folder and replace

recommended (not necessary) go to codebutquick template
find
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/sceditor/jquery.sceditor.bbcode.min.js"></script>

replace

<script type="text/javascript" src="{$mybb->asset_url}/jscripts/sceditor/jquery.sceditor.bbcode.min.js?v=1.4.5.1"></script>

this step force your browser to get new (edited) version from server.

[Leefish]

ok, I will have ago, but isnt that going to break it for iOS? Removing the lines

{
				// Must use an element that isn't display:hidden or visibility:hidden for iOS
				// so create a special blur element to use
				if(!$blurElm)
					$blurElm = $('<input style="position:absolute;width:0;height:0;opacity:0;border:0;padding:0;filter:alpha(opacity=0)" type="text" />').appendTo($editorContainer);

				$blurElm.removeAttr('disabled').show().focus().blur().hide().attr('disabled', 'disabled');
			}

?

I did as you said and now I have no editor at all. I will just revert it all and the firefox users will just have to suffer.

[martec]

ok, I will have ago, but isnt that going to break it for iOS? Removing the lines

{
				// Must use an element that isn't display:hidden or visibility:hidden for iOS
				// so create a special blur element to use
				if(!$blurElm)
					$blurElm = $('<input style="position:absolute;width:0;height:0;opacity:0;border:0;padding:0;filter:alpha(opacity=0)" type="text" />').appendTo($editorContainer);

				$blurElm.removeAttr('disabled').show().focus().blur().hide().attr('disabled', 'disabled');
			}

?

i don´t know...
this fix isn´t mine... you need ask to samclarke (developer of sceditor)
https://github.com/samclarke/SCEditor/co...6ea008981f
and this bug not related with this plugin but with sceditor. so that's all I can do for you.

[Leefish]

Martec - sorry if I did not make that clear; I am totally aware that this Firefox issue has nothing to do with your plugin, and is a KNOWN BUG in sceditor 1.4.5, and thank you for trying to help us.

I asked as you had posted the link to the 1.4.6 dev repo on github in a previous post saying it was the fix.

I get the impression that you dont run this "fix" on your own site then?

[martec]

Martec - sorry if I did not make that clear; I am totally aware that this Firefox issue has nothing to do with your plugin, and is a KNOWN BUG in sceditor 1.4.5, and thank you for trying to help us.

I asked as you had posted the link to the 1.4.6 dev repo on github in a previous post saying it was the fix.

I get the impression that you dont run this "fix" on your own site then?

i use this fix, but mine file is jquery.sceditor.js + bbcode.js + pt_br.js
yes i avoid to use default mybb function to sceditor...
and my template of codebutton etc... is totally diferent of default...

and i hate apple product... so i don´t know if ios has problem with sceditor or not...