[Pushed] Editor bugs - Spacing/removing bbcode
#1
[list]
[*][quote]PS4 GTA 5 uses DualShock 4 speaker for phone calls & police radio, lightbar flashes red & blue during pursuits, touchpad to change weapon[/quote]

https://mobile.twitter.com/VG_Dave/status/529692327288528896

[*]New screenshots of GTA 5 on PS4

http://imgur.com/a/E5xUa

[*]PS4 First Person Gameplay
[/list]
[video=youtube]http://www.youtube.com/watch?v=7oFmRN0oadI[/video]

I will continue to update the thread as more information is released. Most of these things were confirmed by IGN's 1 hour gameplay of GTA 5.

Will appear as:

[Image: d9l0xfX.png]

There is also the issue of copy/pasting and it will remove several elements like the quote tag.

Thank you.
Reply
#2
what?

space in list tag?
this isn´t problem with editor, but com parser of mybb. You can go to WYSIWYG mode and return to source mode, spacing between the link and the item list is kept intact in editor.

quote tag in list tag? you are improperly using the tag list

and check code of sceditor

		var validChildren = {
			ul: ['li', 'ol', 'ul'],
			ol: ['li', 'ol', 'ul'],
			table: ['tr'],
			tr: ['td', 'th'],
			code: ['br', 'p', 'div']
		};

https://github.com/samclarke/SCEditor/bl...e.js#L1255

Quote tag isn´t validChildren of list tag. Is not impossible thing to change, but personally it does not make much sense.
Reply
#3
(2014-11-05, 01:14 AM)martec Wrote: what?

space in list tag?
this isn´t problem with editor, but com parser of mybb. You can go to WYSIWYG mode and return to source mode, spacing between the link and the item list is kept intact in editor.

quote tag in list tag? you are improperly using the tag list

and check code of sceditor

		var validChildren = {
			ul: ['li', 'ol', 'ul'],
			ol: ['li', 'ol', 'ul'],
			table: ['tr'],
			tr: ['td', 'th'],
			code: ['br', 'p', 'div']
		};

https://github.com/samclarke/SCEditor/bl...e.js#L1255

Quote tag isn´t validChildren of list tag. Is not impossible thing to change, but personally it does not make much sense.
There is still the issue of spacing after a link within the list tags. I think the best alternative is making your own bullet points with -
Reply
#4
(2014-11-05, 04:58 AM)mikeh Wrote: There is still the issue of spacing after a link within the list tags. I think the best alternative is making your own bullet points with -

plz, an example

if you saying again about spacing between the link and the item list, this isn´t problem with editor, but with parser of mybb

and i don´t know why mybb remove white line in lista tag, and i don´t know if this is intentional
Reply
#5
When I post a paragraph and put a space before the next paragraph, it goes away when I submit. It doesn't happen on this board, but it does on mine since 1.8.01. So something went funny somewhere.
Reply
#6
(2014-11-05, 04:58 AM)mikeh Wrote: There is still the issue of spacing after a link within the list tags. I think the best alternative is making your own bullet points with -

fix of spacing...

in root/inc/class_parser.php

find:

$message = preg_replace("#\s*\[\*\]\s*#", "</li>\n<li>", $message);

replace:

$message = preg_replace("#\[\*\]\s*#", "</li>\n<li>", $message);

before fix:

In editor:

[Image: ae8OWCs.png]

In postbit

[Image: e8Q6sxM.png]

after fix:

In editor:

[Image: ae8OWCs.png]

In postbit

[Image: b6hoIu6.png]

as you can see it's definitely not a problem caused by the editor
Reply
#7
(2014-11-06, 01:11 PM)martec Wrote:
(2014-11-05, 04:58 AM)mikeh Wrote: There is still the issue of spacing after a link within the list tags. I think the best alternative is making your own bullet points with -

fix of spacing...

in root/inc/class_parser.php

find:

$message = preg_replace("#\s*\[\*\]\s*#", "</li>\n<li>", $message);

replace:

$message = preg_replace("#\[\*\]\s*#", "</li>\n<li>", $message);

before fix:

In editor:

[Image: ae8OWCs.png]

In postbit

[Image: e8Q6sxM.png]

after fix:

In editor:

[Image: ae8OWCs.png]

In postbit

[Image: b6hoIu6.png]

as you can see it's definitely not a problem caused by the editor
before \s* in parser for first
[*]
if we remove it this code:
[list]
[*] item 1
[*] item 2
[/list]
will parse to:
<ul>
</li><li> item 1
</li><li> item 2
</li>
</ul>

Note: I don't test it.
AliReza Tofighi
MyBB Persian Support
Reply
#8
(2014-11-13, 02:38 PM)My-BB.Ir Wrote: before \s* in parser for first
[*]
if we remove it this code:
[list]
[*] item 1
[*] item 2
[/list]
will parse to:
<ul>
</li><li> item 1
</li><li> item 2
</li>
</ul>

Note: I don't test it.

sorry...
but I did not understand what you're trying to tell me

for me not has any issue...

[Image: nJrxcAn.png]
Reply
#9
This is still a bug, at least posting a link in a list doesn't work (I've always problems with it in my threads). Not sure whether we should fix it as a bug in MyBB or report to the SCEditor team (if it hasn't been yet).
Support PMs will be ignored!
Reply
#10
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/2143

Thanks for contributing to MyBB!

Regards,
The MyBB Group
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)