Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
1.8 $db->add_column and $db->drop_column
#1
Currently these do not check if a column actually exists before executing the query.  This can lead to ugly SQL errors.  If we change these so the field_exists method is called first, we can verify if the query should run and if not, just simply not execute it.  This also reduces the amount of code plugin authors have to use.
Reply
#2
(2014-11-07, 10:00 PM)dragonexpert Wrote: Currently these do not check if a column actually exists before executing the query.  This can lead to ugly SQL errors.  If we change these so the field_exists method is called first, we can verify if the query should run and if not, just simply not execute it.  This also reduces the amount of code plugin authors have to use.


good idea
My Plugins

PM only paid support
Reply
#3
I don't see why not.

EDIT: maybe except the fact that we'd end up with many duplicaste checks in plugins etc.
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)