[Pushed] 1.8 upgrade on page header javascript format error
#1
line 39 column 35 - Error: document type does not allow element "br" here

line 49 column 56 - Error: document type does not allow element "img" here

I am validating the html page, the HTML validator is complaining about these

	var loading_text = 'Loading. <br />Please Wait..';
	var spinner_image = "/_static/images/spinner.gif";

I see this can be fixed using the html comment inside javascript tags, however do you have any better recommendation?
Visit our <// Code Tryout //> | MyBB plugins: Addthis
Reply
#2
Why another recommendation is needed? The CDATA comment trick should work just fine and I don't think there are any better alternatives.

Anyways, moving to Bug Report since we should fix in in the core too (and it has nothing to do with upgrading).
Reply
#3
Do we want to fix this? If so it should be pushed Wink
Support PMs will be ignored!
Reply
#4
This is basically the same thing as: http://community.mybb.com/thread-169812.html I think I accidentally removed the <!-- --> in one or two templates in my PR and I see nothing against readding them.

Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/2096

Thanks for contributing to MyBB!

Regards,
The MyBB Group
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)