[Pushed] $groupperms not always set in forum_permissions()

[Devilshakerz]

The $groupperms variable is defined and used in separate, parallel if conditions which may result in passing an undefined variable to the fetch_forum_permissions() function.

defined:
https://github.com/mybb/mybb/blob/featur....php#L1315
https://github.com/mybb/mybb/blob/featur....php#L1326

used:
https://github.com/mybb/mybb/blob/featur....php#L1349
https://github.com/mybb/mybb/blob/featur....php#L1359

[Jones H]

There are thousands of cases like this Especially n functions.php

[Jones H]

Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/2123

Thanks for contributing to MyBB!

Regards,
The MyBB Group