[Pushed] Wrong line endings in php files (Development Standard)
#1
I noticed that some of the files of the project don't follow the http://docs.mybb.com/1.8/development/standards/

MyBB Development Standards Wrote:New Lines

All new lines should be denoted by the UNIX line feed (\n, also known as "LF") and not include the Windows carriage return (\r, also known as "CR"). CR and CRLF are not permitted; LF is the only permitted line ending.

The full list of the 1.8.5 release with wrong line endings (crlf instead of lf only):

admin\styles\default\style.php
inc\3rdparty\2fa\GoogleAuthenticator.php
inc\db_sqlite.php
install\resources\upgrade25.php
member.php
usercp2.php

It would be nice to see these, maybe with 1.8.6, corrected to follow the UNIX standard of lf only like the rest of the files. I know that such a change isn't easy to do (especially for the last two files), because it may result in difficulties for merges from other developers/forks in some cases.
Reply
#2
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/2157

Thanks for contributing to MyBB!

Regards,
The MyBB Group
Reply
#3
Note that we should also probably add a .gitattributes file if one doesn't already exist to force Unix line-endings. It does bug me having different mixes of line endings too.
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)