[Rejected] Page Count Bug

[Ben]

I see 7 pages here but 8 pages here

[StefanT]

Without knowing how to reproduce the bug we can't fix it.

[Ben]

Sorry, I meant to reply to this thread again. There is one unapproved post on the thread so they're not taken into account on forum view for page numbers or total replies for staff.

[Destroy666]

This definitely isn't correct: https://github.com/mybb/mybb/blob/featur...p#L926-927 Not sure what $visible is doing there when the next line assumes everything can be viewed...

And the whole block is not even available in forumdisplay.php = counts are not queried, which is the only big difference I noticed. For guests pages in that thread are always 1-7, which also suggests it's mod-related.

EDIT: and ofc this isn't correct when it comes to permissions: https://github.com/mybb/mybb/blob/featur....php#L1118 but there's an issue for many similar cases already. The conditional doesn't make any sense either since it considers only unapproved posts while soft deleted are also added - that's likely the cause.

[Ben]

Do we want to go ahead and tackle this issue?

[Omar G.]

Good luck, haha

Now seriously, tracking pagination bugs has always been difficult. Hopefully, they will fix themselves as we rewrite the code.

[Shade]

As Omar said, this may already have been fixed. I can't reproduce this anymore.

[effone]

I have fixed it or something similar in some PR if I can remember. May be ...