Jump to the post that solved this thread.
Solved: 4 Years, 11 Months, 1 Week ago MyBB v1.8.9 - cookie secure flag issue
#1
Solved: 4 Years, 11 Months, 1 Week ago
Hi guys, after upgrade from v1.8.8 to v1.8.9 I get this error in my console (Google Chrome). Secure cookie in ACP is disabled (double checked).

No issue on MyBB 1.8.8. Any advise? Thank you

EDIT: FIXED! Somehow this was missing in headerinclude

var cookieSecureFlag = "{$mybb->settings['cookiesecureflag']}";


Attached Files Thumbnail(s)
   
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#2
Solved: 4 Years, 11 Months, 1 Week ago
This is a bug related to https://github.com/mybb/mybb/issues/2464 - the headerinclude template version (the version="1907" in https://github.com/mybb/mybb/blob/featur...xml#L13981) wasn't changed to 1809, which resulted in the template not being updated in modified themes and the Find Updated Templates utility not displaying these changes.

Although it shouldn't break other functionality, the Secure Cookie Flag will not be in full effect until proper changes are made; MyBB 1.8.10 will contain the updated template.

This issue can be fixed either by manually changing the version attribute in install/resources/mybb_theme.xml (line 13981) to 1809 before upgrading, or by updating the Ungrouped Templates → headerinclude after running the upgrade script:
<link rel="alternate" type="application/rss+xml" title="{$lang->latest_threads} (RSS 2.0)" href="{$mybb->settings['bburl']}/syndication.php" />
<link rel="alternate" type="application/atom+xml" title="{$lang->latest_threads} (Atom 1.0)" href="{$mybb->settings['bburl']}/syndication.php?type=atom1.0" />
<meta http-equiv="Content-Type" content="text/html; charset={$charset}" />
<meta http-equiv="Content-Script-Type" content="text/javascript" />
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.js?ver=1806"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.plugins.min.js?ver=1806"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1809"></script>
{$stylesheets}
<script type="text/javascript">
<!--
	lang.unknown_error = "{$lang->unknown_error}";
	lang.select2_match = "{$lang->select2_match}";
	lang.select2_matches = "{$lang->select2_matches}";
	lang.select2_nomatches = "{$lang->select2_nomatches}";
	lang.select2_inputtooshort_single = "{$lang->select2_inputtooshort_single}";
	lang.select2_inputtooshort_plural = "{$lang->select2_inputtooshort_plural}";
	lang.select2_inputtoolong_single = "{$lang->select2_inputtoolong_single}";
	lang.select2_inputtoolong_plural = "{$lang->select2_inputtoolong_plural}";
	lang.select2_selectiontoobig_single = "{$lang->select2_selectiontoobig_single}";
	lang.select2_selectiontoobig_plural = "{$lang->select2_selectiontoobig_plural}";
	lang.select2_loadmore = "{$lang->select2_loadmore}";
	lang.select2_searching = "{$lang->select2_searching}";
	var cookieDomain = "{$mybb->settings['cookiedomain']}";
	var cookiePath = "{$mybb->settings['cookiepath']}";
	var cookiePrefix = "{$mybb->settings['cookieprefix']}";
	var cookieSecureFlag = "{$mybb->settings['cookiesecureflag']}";
	var deleteevent_confirm = "{$lang->deleteevent_confirm}";
	var removeattach_confirm = "{$lang->removeattach_confirm}";
	var loading_text = '{$lang->ajax_loading}';
	var saving_changes = '{$lang->saving_changes}';
	var use_xmlhttprequest = "{$mybb->settings['use_xmlhttprequest']}";
	var my_post_key = "{$mybb->post_code}";
	var rootpath = "{$mybb->settings['bburl']}";
	var imagepath = "{$theme['imgdir']}";
  	var yes_confirm = "{$lang->yes}";
	var no_confirm = "{$lang->no}";
	var MyBBEditor = null;
	var spinner_image = "{$theme['imgdir']}/spinner.gif";
	var spinner = "<img src='" + spinner_image +"' alt='' />";
	var modal_zindex = 9999;
// -->
</script>
You can view the specific changes at https://github.com/mybb/mybb/pull/2468/f...9b667b44b8.
devilshakerz.com/pgp (DF3A 34D9 A627 42E5 BC6A 6750 1F2F B8AA 28FF E1BC) ▪ keybase.io/devilshakerz
Reply
#3
Solved: 4 Years, 11 Months, 1 Week ago
Yes, I know. I fixed it myself - just add these changes manually. There should be released new updated build soon
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#4
Solved: 4 Years, 11 Months, 1 Week ago
So before running update, this must be added or:

[Image: ab257a7c18da43a0b2816c1600637d66.png]

Just wanna make sure.
Reply
#5
Solved: 4 Years, 11 Months, 1 Week ago
(2016-12-22, 09:17 PM)thelovelyone Wrote: So before running update, this must be added or:

[Image: ab257a7c18da43a0b2816c1600637d66.png]

Just wanna make sure.

Both modifications need to be applied - the first one changes ?ver=1907 to ?ver=1809 and the second one adds the JavaScript variable.
devilshakerz.com/pgp (DF3A 34D9 A627 42E5 BC6A 6750 1F2F B8AA 28FF E1BC) ▪ keybase.io/devilshakerz
Reply
#6
Solved: 4 Years, 11 Months, 1 Week ago
So will there be a new Changed Files Package 1.8.9 version to download or will we all have to make the changes ourselves. ?

I always hold off for a week or two before upgrading as I don't like messing with things.
Reply
#7
Solved: 4 Years, 11 Months, 1 Week ago
Nothing difficult to add one line into headerinclude template. Anyway MyBB team would release fixed package soon
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#8
Solved: 4 Years, 11 Months, 1 Week ago
The changes were already there when i checked it, so prob applied already.
Reply
#9
Solved: 4 Years, 11 Months, 1 Week ago
Had this issue as well, cheers for the fix.
Reply
#10
Solved: 4 Years, 11 Months, 1 Week ago
now pack is updated with good modifications or?

https://blog.mybb.com/
mybb 1.8.8 to 1.8.9?

because i installed the upgrade and in headerinclude nothing appear...with cookiesecure or 1809...i tested on another board....so i will stay with 1.8.8...



after update :

<script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.js?ver=1806"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.plugins.min.js?ver=1806"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1807"></script>

and cookiesecure don't appear...
so..please upgrade files
i have 3 themes...
Reply
Jump to the post that solved this thread.


Forum Jump:


Users browsing this thread: 1 Guest(s)