Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[Pushed] Bad word filter
#11
Oh my, I didn't know I will have such a huge impact on the myBB development ^^
Reply
#12
There will be one improvement in MyBB 1.8.16 - https://github.com/mybb/mybb/issues/2225 - we can improve it in v1.8.17 with another "feature", why not if it is useful Smile
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#13
I am really looking forward to it! Without this, mybb forum can not be properly protected from curses
Reply
#14
(06-12-2018, 08:03 AM)effone Wrote: Form the attempts described above I tried to reproduce this and what I have found is:
The filter is working perfectly, with or without the * sign. But there are improvements required.

1. If you try to filter `stone` with `metal` it works fine (spaces surrounded).
2. If you try to filter `stone*` with `metal` the word 'stone' will not be replaced until a character other than space is appended. For example 'stoner' will be replaced perfectly. The behavior should not be like that. The filter should occur with or without character appended.
3. Currently it is considering '*' as a single character. So to filter out 'stoneman' or 'stoneboy' you need to place the target word as 'stone***'. which is again wrong. Single character should be represented by '?' and '*' should be representing 0 or more characters.

There is, ofcourse an issue with filtering and needs to be improved. Good catch. But I'd like to listen from other devs before moving it to Github.
For now, moving it to 1.8 bugs and issues.

Yep, that's why it works for me, but not for Ramireo. 

You are correct in terms of using '?' for single characters and '*' for more than 1 character. That's a leftover from the old DOS command line days.
I never understood why it was set up that way in the original Word Filter coding. I just accepted it as is and moved on.
Reply
#15
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/3262

Thanks for contributing to MyBB!

Regards,
The MyBB Group
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)