[Pushed] Remove attachment Text BBcode into Post
#1
Remove attachment Text BBcode into Post

When Edit a post can delete or add attachment  and can -Insert into a Post -

but When Remove attachment... The BBCode  - Insert into a Post -  Still in the Post!

[Image: O2X4zDA.png]

Reproduction steps
1. Create a post with attachment.
2. Add Attachment.
3. - Insert into a Post -  Buton BBCode
4. Post Reply.

Issue:
When Delete the Attachment  The BBCode -Insert into a Post -  Still in the Post!

- It would be good to delete the BBcode from the Post too!


it's just a suggestion... The Software its Amazing!

Thank you!  Smile
Reply
#2
Confirmed, after removing attachment code in editor isn't removed.

Maybe it's because removing actual text from editor is not so easy to do by php script.

Edit: confirmed, but not considered as issue / bug. It is impossible to easily remove attachment code from editor. And editor doesn't have any functions to remove specified text. Since attachment code isn't exactly a bbcode it is not parsed by SCEditor, and only by MyBB.
It should be possible maybe if we try to change source mode and wysiwyg mode editor "windows" values.
Reply
#3
Not sure if this is still needed but managed to find a hot fix.

https://github.com/veryard/mybb/commit/b...1a420837c1

Preview:
https://gfycat.com/scentedtestyfieldspaniel

Thanks,
Brad.
Reply
#4
(2019-03-06, 09:30 AM)MinusPL Wrote: It is impossible to easily remove attachment code from editor. And editor doesn't have any functions to remove specified text.

Actually, the attachment BBCode is easy to remove both in JS and PHP. This should be added as a low-priority enhancement in future updates.
[Image: fSGNVQj.png]
Reply
#5
Yes, I provided a solution on Github: https://github.com/mybb/mybb/pull/3629

Thanks.
Reply
#6
I can't find the issue in Github.
Can anyone link me?
Reply
#7
I think there is no issue for that PR. Anyway it is a valid report.
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#8
Then the thread prefix is purely manual?
Why the .... :@
Reply
#9
Brad, I have recommended something in your PR. See if its logical.
Reply
#10
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/3644

Thanks for contributing to MyBB!

Regards,
The MyBB Group
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)