MyBB Community Forums › Development › MyBB 1.8 Development › 1.8 Bugs and Issues › Pushed v
[Pushed] Update attachment

Threaded Mode
[Pushed] Update attachment
effone Offline

Development
Posts: 4,217
Threads: 120
Joined: May 2012
Reputation: 497
#1
2019-03-29, 05:56 PM (This post was last modified: 2019-03-29, 05:58 PM by effone.)
Completely confused about "Update Attachment" button. The thing its doing currently is nothing but what "Add Attachment" does. So why the button is there? Can anyone guide me in which step this buttons action is unique?

This button should be removed or if really intended to update the attachment - it should be multiple, per already attached file list.
Point me out if I am missing something.

And now the bug:

We have switched to AJAX file remove. Well.
Update attachment appears only if atleast one file is already attached. But AJAX delete does not respect it.
Remove all the already attached files - "Update Attachment" button is still there. Refresh the page - its gone.
Website Find
Reply
Eldenroot Offline

Contributor
Posts: 3,317
Threads: 192
Joined: May 2014
Reputation: 147
#2
2019-03-29, 07:46 PM
Hmm, it should be removed all changed to "Remove all"
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Website Find
Reply
doylecc Offline

Big Board Owner
Posts: 468
Threads: 19
Joined: Jul 2008
Reputation: 66
#3
2019-03-29, 10:19 PM
(2019-03-29, 05:56 PM)effone Wrote: Completely confused about "Update Attachment" button. The thing its doing currently is nothing but what "Add Attachment" does. So why the button is there? Can anyone guide me in which step this buttons action is unique?

If the file name of the new uploaded file is the same as the old attachment with "Update Attachment" it keeps the old attachment-id, which comes handy if you have inserted the attachment into the post or linked it somewhere else since the link won't go dead.
My plugins | Enhanced Account Switcher
Website Find
Reply
effone Offline

Development
Posts: 4,217
Threads: 120
Joined: May 2012
Reputation: 497
#4
2019-03-30, 01:54 AM (This post was last modified: 2019-03-30, 01:57 AM by effone.)
Well. A point. But
Why the button appears in new thread then?
Where it is documented to make general users educate?
Why it acts like add attachment when nothing is being updated actually? An error or atleast a notice is expected.
If you want to replace an uploaded file you have to rename it? Isn't it silly?

I know upload management is huge thing but noticed many such issues. I forgot the steps but have noticed uploaded attachment gets missing with a return page triggered by an error.
Website Find
Reply
Eldenroot Offline

Contributor
Posts: 3,317
Threads: 192
Joined: May 2014
Reputation: 147
#5
2019-05-24, 11:25 AM
I vote to remove it
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Website Find
Reply
Ben Offline

Community

Support
Posts: 3,112
Threads: 212
Joined: Nov 2014
Reputation: 150
#6
2020-01-05, 03:07 PM
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/3873

Thanks for contributing to MyBB!

Regards,
The MyBB Group
Find
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)