[Pushed] Template Bug: modcp_announcements_edit input name attribute
#1
The name attribute of the input element seems to be set unintentionally and needs an update.

Version: 1.8.21 / Original MyBB Theme.

Template (line 74):
modcp_announcements_edit

XML resource:
./install/resource/mybb_theme.xml (line 6474):

<input type="submit" class="button" name="Edit Announcement" value="{$lang->edit_announcement}" />&nbsp;&nbsp;

[ExiTuS]

Edit: The same for modcp_announcements_new

Template (line 73):
modcp_announcements_new

XML resource:
./install/resource/mybb_theme.xml (line 6604):

<input type="submit" class="button" name="Add Announcement" value="{$lang->add_announcement}" />&nbsp;&nbsp;

[ExiTuS]
New Forum / MyBB 1.8.24 + innovative full-responsive Theme
Live-Escape-Game-Forum
Reply
#2
I am not sure about this one... it is needed for JS reference. MyBB team thoughts?
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#3
How come it is needed for JS? Could you elaborate? If that is the case, we could use key names, like name="add_annoucement".

The current state makes it unnecessarily confusing as it might be to even fix it.
Reply
#4
Ok, you are right. Feel free to push a PR Smile I think there are only these two mentioned above
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#5
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/3967

Thanks for contributing to MyBB!

Regards,
The MyBB Group
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)