[Pushed] Inconsistent spaces around "] = " in language files
#1
Information 
I found 22 lines with inconsistent spaces around the "] = " in the english language files.  Doubtful that it will break anything, but as there are 3459 that are consistent, perhaps these 22 lines should be the same.

Attached is a spreadsheet showing current text and what would be consistent.[Image: kQAKx76.png]
Reply
#2
Thanks for reporting.
Reply
#3
Just cosmetics with no effect on function... but it makes modest quality Smile
Keen-eyed, great!

[ExiTuS]
New Forum / MyBB 1.8.24 + innovative full-responsive Theme
Live-Escape-Game-Forum
Reply
#4
I can make a PR or if you can, would be great!
[MyBB 1.8 Czech translation] [MyBB 1.8 plugins]: Prune old PMs + optimize DB plugin --- Thank you/like system
Reply
#5
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/4107

Thanks for contributing to MyBB!

Regards,
The MyBB Group
Reply
#6
Great, glad to help. I'll note that I'm not quite so keen-eyed, I had to work around this problem in my Translate tool that's nearing completion and will replace my previous version Smile
https://community.mybb.com/thread-227986.html
Reply
#7
(2020-07-03, 03:55 PM)RadiKalli Wrote: Great, glad to help. I'll note that I'm not quite so keen-eyed, I had to work around this problem in my Translate tool that's nearing completion and will replace my previous version Smile
https://community.mybb.com/thread-227986.html

Good stuff, keep up the good work and I can already tell that I enjoy the way you are thinking... Big Grin
Reply
#8
(2020-07-03, 06:52 PM)vintagedaddyo Wrote:
(2020-07-03, 03:55 PM)RadiKalli Wrote: Great, glad to help. I'll note that I'm not quite so keen-eyed, I had to work around this problem in my Translate tool that's nearing completion and will replace my previous version Smile
https://community.mybb.com/thread-227986.html

Good stuff, keep up the good work and I can already tell that I enjoy the way you are thinking... Big Grin

Thank you, I am unaware of a better compliment.  Thinking is  a big one Big Grin

I found a couple more lines in the admin files and commented on the Git report.  What a difference this will make, nobody will ever know! 

I did complete the replacement of my tool today, perhaps it will be useful for more than translating, but very useful for that.  Very nice to have all the lines of all the files in one spreadsheet, but I am unable to evaluate other possible ways to apply it.

Anyhow, time to start translating... finally Smile
Reply
#9
I downloaded 1823 and 1824 yesterday and found the same inconsistencies as before.  I commented on the github PR yesterday, I'll leave the results here as well.

https://github.com/mybb/mybb/pull/4120


Attached Files
.zip   2021.01.16 Inconsistencies.xlsx.zip (Size: 7.8 KB / Downloads: 6)
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)