[Pushed] User activity ignored for subscriptions

[StefanT]

There is this check that is supposed to prevent sending notifications to users that haven't been online since they received the last notification.
inc/datahandlers/post.php:

					AND u.lastactive > '{$forum['lastpost']}'

However the conditions is always true because $forum['lastpost'] is always 0.

$forum is loaded from datacache which excludes some fields:

		// Things we don't want to cache
		$exclude = array("unapprovedthreads", "unapprovedposts", "threads", "posts", "lastpost", "lastposter", "lastposttid", "lastposteruid", "lastpostsubject", "deletedthreads", "deletedposts");

That causes MyBB to send out way more notifications that it should and may flood users that have subscribed to a popular forum. I'm surprised nobody has complained about this yet.

[StefanT]

Can you please push this bug report? I'd like to prepare a pull request.

[Ben]

Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/4160

Thanks for contributing to MyBB!

Regards,
The MyBB Group