Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Drop legacy support for yes and no options
#1
1.8 has support for legacy option values of yes and no, for backwards plugin compatibility (1.4, probably 1.6 too).

I think this should be dropped altogether for 1.9. First, it makes the read of the code more complicate, plus any plugin with such outdated practices is probably already too old to be trust or is not supported at all (by anyone).
Send me a DM or PM if you want to sponsor any update or addition to my plugins.

[Image: signature.png]

Discord omar.gonzalez (Omar G.#6117); Telegram at @omarugc;
Reply
#2
I'll agree for it to be dropped in 1.9 given that plugins will have breaking changes anyway. I think it should still exist in the 1.8 series for compatibility.
Reply
#3
Hi,

Your feature suggestion has been accepted as a planned feature to be implemented in MyBB. Thanks for your contribution!
-Ben
Reply
#4
Do we have references related to onoff & yesno evolution?

Core settings use both.

They produce different text, so there's some value.

Removing them may cause more hassle than leaving them in, given simple implementation.
devilshakerz.com/pgp (DF3A 34D9 A627 42E5 BC6A 6750 1F2F B8AA 28FF E1BC) ▪ keybase.io/devilshakerz
Reply
#5
I actually thought they were more about legacy code, I never noticed there are different language strings used for Yes/On and No/Off ...

Edit: We should probably split them and make one be a wrapper for the other, if they are both useful
Send me a DM or PM if you want to sponsor any update or addition to my plugins.

[Image: signature.png]

Discord omar.gonzalez (Omar G.#6117); Telegram at @omarugc;
Reply
#6
In https://docs.mybb.com/1.8/development/pl...g-settings onoff and yesno are listed, I think a lot of plugins use the two. I also know most plugins (all ?) will have to be rewrited, but having an "intelligent" parser to treat the two in the same way but with the good wording could be a wonderful gift for lazzy developpers as me Big Grin
Tchat en français
Do not ask me help through PM or Discord

Reply
#7
I think they are actually already split, so I'm unsure what my whole suggestion is about now ...
Send me a DM or PM if you want to sponsor any update or addition to my plugins.

[Image: signature.png]

Discord omar.gonzalez (Omar G.#6117); Telegram at @omarugc;
Reply
#8
https://github.com/mybb/mybb/issues/5159
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)