[Pushed] PHP8 warning for Get More Smilies

[HLFadmin]

If a post is created and there are more defined smilies than show in the smilies list, and Get More is clicked, it throws a warning
Undefined variable $pid in eval'd code line 2 called from /forum/misc.php line 817.

The default template misc_smilies_popup invokes a div with class="modal_{$pid}
I'm not sure why that class is named with a pid.

I cleared the warning by adding a line at 816

$pid = '';

[Eldenroot]

https://github.com/mybb/mybb/pull/4660

[schauan]

Hello,

is there a better way to show the close - "x" in foreground? 
Without _{$pid} we see only a little bit of it because it is in background ... 

picture ..01 with class="modal", picture ..02 with class="modal_{$pid}" 

       

[bv64]

@Laird could you share this on github too? The problem exists in principle, even here in the board

[Laird]

Done, if I've understood correctly what you were wanting reported (let me know if not):

https://github.com/mybb/mybb/issues/4853

[bv64]

you did understood, sorry, early morning, still in lazy writing mode

edit 2 hours later: now I get it, I had slipped in the topic