[F] Thumbnails Not Rebuilding [C-Michael83]

[User 2877]

Edit: check_proceed for Thumbnnails is certainly not working.

---

Found 2 typos in the acp_rebuild_attachment_thumbnails function so far:

function acp_rebuild_attachment_thumbnails()
{
global $db, $mybb, $lang;

$query = $db->simple_select("attachments", "COUNT(aid) as num_attachments");
$num_attachments = $db->fetch_field($query, 'num_attachments');

$page = intval($mybb->input['page']);
$per_page = intval($mybb->input['attachmentthumbs']);
$start = ($page-1) * $per_page;
$end = $start + $per_page;

require_once MYBB_ROOT."inc/functions_image.php";

$query = $db->simple_select("attachments", "*", '', array('order_by' => 'aid', 'order_dir' => 'asc', 'limit_start' => $start, 'limit' => $per_page));
while($attachment = $db->fetch_array($query))
{

$ext = my_strtolower(my_substr(strrchr($attachment['filename'], "."), 1));
if($ext == "gif" || $ext == "png" || $ext == "jpg" || $ext == "jpeg" || $ext == "jpe")
{
$thumbname = str_replace(".attach", "_thumb.$ext", $attachment['attachname']);

$thumbnail = generate_thumbnail(MYBB_ROOT."uploads/".$attachment['attachname'], MYBB_ROOT."uploads/", $thumbname, $mybb->settings['attachthumbh'], $mybb->settings['attachthumbw']);

if($thumbnail['code'] == 4)
{
$thumbnail['filename'] = "SMALL";
}
$db->update_query("attachments", array("thumbnail" => $thumbnail['filename']), "aid='{$attachment['aid']}'");
}
}

check_proceed($num_attachments, $end, ++$page, $per_page, "attachmentthumbs", "do_rebuildattachmentthumbs", $lang->success_rebuilt_attachment_thumbnails);
}

One is a path problem where after uploads it needed to be uploads/.
Two is $num_users should be $numb_attachments so that the proceed works.

fyi- I wasn't able to rebuild my thumbnails without manually chmod of 666. Not sure if that's partly my servers safe mode or something mybb isn't doing well. Either way I found two bugs.

Thanks.

[Ultron]

When i change the thumbnails size on ACP it never rebuilds the old, just changes to the ones inserted after that change.

[User 2877]

Fix the typos I have above and you can rebuild successfully.

I am sure this will be added to bug fixes soon as possible.

[Yumi]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

With regards,
MyBB Group