Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[F] url with brackets [C-Michael83]
#1
that must be a bug:

urls containing brackets are not completley shown
Example:

http://www.airlinetest.com/index.php?id=topdetails&no_cache=1&uid=447&tx_ttnews[swords]=Lufthansa

as a link: http://www.airlinetest.com/index.php?id=...&tx_ttnews[swords]=Lufthansa

Someone has a solution?

Thanks
RII
www.info-tunesien.de
German Site about Tunisia!
#2
Those characters aren't valid in URLs, so it's not a bug...

(most browsers convert "[" to "%5B" and "]" to "%5D" - therefore, the correct URL for the above is:
http://www.airlinetest.com/index.php?id=...=Lufthansa )
#3
(10-04-2008, 01:00 PM)ZiNgA BuRgA Wrote: Those characters aren't valid in URLs, so it's not a bug...

(most browsers convert "[" to "%5B" and "]" to "%5D" - therefore, the correct URL for the above is:
http://www.airlinetest.com/index.php?id=...=Lufthansa )

Yea most browsers convert them so why shouldn't it be fixed?
Convert [] to &5B and %5D, so that users don't have to. And if you just write [] in an url the browser will recognize it so I don't see why this shouldn't be fixed.
#4
We can't fix everything.
It's problematic - there's no way to tell if the brackets inserted for the auto URL was intentional or not.

For example:

Visit http://google.com[best search engine]
http://example.com(my website)
https://somesite.com/
#5
(10-05-2008, 11:19 PM)ZiNgA BuRgA Wrote: We can't fix everything.
It's problematic - there's no way to tell if the brackets inserted for the auto URL was intentional or not.

For example:

Visit http://google.com[best search engine]
http://example.com(my website)
https://somesite.com/

oh, I thought it was when using the [url] tag.
Anyways, people should be able to use space after a url anyways.
#6
http://www.airlinetest.com/index.php?id=...=Lufthansa
Dennis Tsang
Former MyBB Team Member
Web: http://dennistt.net
#7
(10-06-2008, 07:52 AM)DennisTT Wrote: http://www.airlinetest.com/index.php?id=...=Lufthansa

Okey so it doesn't work inside the url tags either. Shouldn't it?
#8
(10-06-2008, 07:33 AM)CraKteR Wrote:
(10-05-2008, 11:19 PM)ZiNgA BuRgA Wrote: We can't fix everything.
It's problematic - there's no way to tell if the brackets inserted for the auto URL was intentional or not.

For example:

Visit http://google.com[best search engine]
http://example.com(my website)
https://somesite.com/

oh, I thought it was when using the [url] tag.
Anyways, people should be able to use space after a url anyways.
Possibly, but then [http://google.com] would break...

Inside the URL tag should probably be fixed though I guess, though I like sticking to URL standards. (easy fix, just remove the []'s from the regex).
#9
(10-06-2008, 10:40 PM)ZiNgA BuRgA Wrote:
(10-06-2008, 07:33 AM)CraKteR Wrote:
(10-05-2008, 11:19 PM)ZiNgA BuRgA Wrote: We can't fix everything.
It's problematic - there's no way to tell if the brackets inserted for the auto URL was intentional or not.

For example:

Visit http://google.com[best search engine]
http://example.com(my website)
https://somesite.com/

oh, I thought it was when using the [url] tag.
Anyways, people should be able to use space after a url anyways.
Possibly, but then [http://google.com] would break...

Inside the URL tag should probably be fixed though I guess, though I like sticking to URL standards. (easy fix, just remove the []'s from the regex).

Well then you should convert the []'s. As they are supported. And every browser converts them to [] and if you copy it it will be [].
#10
Okay, I've added some URL entity fixes for URLs inside [url] tags. Would anyone be able to confirm that these changes don't break anything?
(replace inc/class_parser.php with the supplied file)

Thanks!


Attached Files
.php   class_parser.php (Size: 29.66 KB / Downloads: 337)


Forum Jump:


Users browsing this thread: 1 Guest(s)