MyBB

Dear flick
I have found a Bug,
When my users try to register on my forum
In Password input box,
when they enter there required password
this error message appears,

The passwords you enter must match

Please Help

And Please also clearify that How could I Revert this into the original state
that we have found with the mybboard.net zip file of 1.4.4.

My forum URL is this

http://tasawwuf.110mb.com/forum

Thanx
with Regards

Hullo naqshbandios_limra Thanks for your comment and for providing the link to your site. I have to admit I am a little confused by the bug that you mentioned, as this code modification technically shouldn't affect user registration at all because no modifications have been made to that side of the code as far as I am aware at the moment.

The error message you mentioned

(2009-01-02, 12:58 PM)naqshbandios_limra Wrote: The passwords you enter must match

sounds more as though the user might possibly have made a small error when typing in their password the second time during registration. Not sure if you've already reverted the edits, but I tried to register on your forum just now, and it went through just fine. Do you think it might be possible for you to try registering a new account yourself with the edits?

(2009-01-03, 12:13 AM)flick Wrote: Hullo naqshbandios_limra Thanks for your comment and for providing the link to your site. I have to admit I am a little confused by the bug that you mentioned, as this code modification technically shouldn't affect user registration at all because no modifications have been made to that side of the code as far as I am aware at the moment.

The error message you mentioned

(2009-01-02, 12:58 PM)naqshbandios_limra Wrote: The passwords you enter must match

sounds more as though the user might possibly have made a small error when typing in their password the second time during registration. Not sure if you've already reverted the edits, but I tried to register on your forum just now, and it went through just fine. Do you think it might be possible for you to try registering a new account yourself with the edits?

Dear flick,
I am glad to see You on my forum
Dear flick, I have reverted the changed templtes to the original,
And Now my users are Registering Just fine today
And Yes I also wondering about that registering area
that there is NO Modification at that part at all
But,
As I seen
The Password input Box seems to be Corrupt
Thankyou Flick for your kind comments.
Occassionally I am trying to fix this on my testing forum
Link is here
www.tasawwuf.110mb.com/test

Thanx
Regards

@naqshbandios_limra:

Thanks for the link to the test forum! I do get a different error (permissions error) when I try and register on your test forum, but in terms of your original question, after doing a bit more searching around, I have been able to replicate the problem of passwords not matching... on Internet Explorer.

It turns out that there are several threads relating to this issue, which is that up to IE7 at least (I'm using IE6) the browser doesn't seem to function normally with the Ajax checking if there is more than one password box. There are currently two 'easy' ways around the problem, either:

1. Enable the 'Send random password' feature so users receive a password in their inbox instead of entering their own password; or
   
2. Ask users to also type in the password in the login box when they fill in the registration form. This actually works (I tried it on my local installation) but it's quite a hassle.
   

This problem has been fixed by the MyBB team in the standard default theme for the original 'quick login box', as they added extra code in general.js and member.php (the code below is what they've added to member.php I think and is just for reference as this is available in the most recent versions since 1.4.2)

	// Did we come from the quick login form
	if($mybb->input['quick_login'] == "1" && $mybb->input['quick_password'] && $mybb->input['quick_username'])
	{
		$mybb->input['password'] = $mybb->input['quick_password'];
		$mybb->input['username'] = $mybb->input['quick_username'];
	}

I am not very sure at the moment quite how to modify the code for the login box at the top to ensure that the clash does not occur in IE (it does work fine in Firefox etc.) but I know it's something to do with the input name. Will take a look into this and let you know when I have a result

p/s: Whilst on your test forum, I noticed that your .css file is missing a /* at the front which causes a minor CSS error. You might want to consider editing the file again and adding this part in. It's quite easily missed during copy-paste

Very much thanx flick
I am still not able to fix this on my test forum
Perhaps, this error is due to mistake in copy~pasting from here
Again I am gratful toyou that you helped me and give valuable comments
As you said that , " to send a Random Password"
The problem is that I want Instant activation of new accounts,
And Second is that, If I forced users to also type in the password in the login box when they fill in the registration form, It will make guests a Boaring effect ,
Thats why, I think that I didnot alter any change to it
After Saying this
I am very much thankful to you that you provide us a very good modification
Regards
naqshbandios_limra

Thanks for your kind comments, naqshbandios_limra! The credits for the original modification is thanks to Lapsetur - I really haven't changed much except for provide some of the updated files and a few edits here and there

I am still looking into a solution for the registration issue in IE where passwords do not match and will certainly take a look at your forums as well re: your other registration issue, although I have a feeling it might be related to a plugin clash.

And for others: just to let you all know that the code for the css file and also the headerinclude template has been updated.

Very much thanx flick
Regards

Hi flick,
1) Please tell what the changes in the 'headerinclude' template are. Becase of my editions/changes, not all changes you do apply to me.
2) your code in "nav_sep" template has a problem (in my opinion). Your code, leaves the "old" navigation style. I changed that code so it will create the "ladder" effect. here is my code:

<br /><img style="vertical-align:bottom;" src="{$theme[imgdir]}/nav_bit.gif" />

A few more things:
1) the images I added to the menu are just <img=> - not css changes. I'm sure change using css is better, but I wanted things to look nice as fast and easy for me.
2) the down arrow I use in the added menu was created by inverting the colors on your regular down arrow (this is why it has a redish edges).
3) the added menu was created (more or less) when I copied the code from "Quick Links" into the "header" template and adding a table for it. here is the code (please note that the text WAS in Hebrew, so there could be a RTL base aligment tag that I forgot to change for this forum):

<td class="thead" align="center"><img src="{$mybb->settings['bburl']}/{$theme['imgdir']}/toplinks/adds.gif" alt="" title="" /><a href="index.php" id="additions" onclick="return openMenu(this)" class="popup_button_general">Additional Links<img src="images/popup_down_inverted.gif" border="0" /></a>
<div class="menupop" id="additions-popup" style="display:none" align="right">
<table cellpadding="1" cellspacing="1" border="0">

<tr><td class="thead">Additional Links</td></tr>
<tr><td class="menu_row"><a href="index.php" title="Back to index">Main Page</a></td></tr>
<tr><td class="menu_row"><a href="downloads.php" title="Show files for dowload">Download Files</a></td></tr>
<tr><td class="menu_row"><a href="refer.php" title="Invite your friends to sign to this site">Referral Form</a></td></tr>
<tr><td class="menu_row"><a href="contact.php" title="Contuct the forum administrator using a form">Contact Form</a></td></tr>

<tr><td class="thead"><a href="#" title="Place Holder">Empty Space</a></td></tr>
<tr><td class="menu_row"><a href="#" title=""> </a></td></tr>
<tr><td class="menu_row"><a href="#" title=""> </a></td></tr>
<tr><td class="menu_row"><a href="#" title=""> </a></td></tr>
<tr><td class="menu_row"><a href="#" title=""> </a></td></tr>

<tr><td class="thead">שונות</td></tr>
<tr><td class="menu_row"><a href="#" title=""> </a></td></tr>

<tr><td class="menu_row"><a href="#" title=""> </a></td></tr>
<tr><td class="menu_row"><a href="#" onclick="MyBB.popupWindow('', 'some_place-or-list', 350, 350);" title=""> </a></td></tr>

</table>
</div>
</td>

This was added after the code:

<td class="thead" align="center"><img src="{$mybb->settings['bburl']}/{$theme['imgdir']}/toplinks/search.gif" alt="" title="" /><a href="{$mybb->settings['bburl']}/search.php" id="search" onclick="return openMenu(this)" class="popup_button"> {$lang->toplinks_search}<img src="images/popup_down.gif" border="0" /></a></td>

Hope this helps,
Ori...

@okitai: Thank you for detailing your edits! I have added a link to your post to the first post, so that people can reference it quickly. I'll certainly look into changing the navigation style for nav_sep; this was retained from the original code modification, and having checked out vBulletin's forum quite recently, I assumed this was still quite an up-to-date nav-separator. For those who are wondering, nav_sep_active does have a similar ladder effect as well

And as to the changes to the css file and headerinclude- thanks for bringing this up! I really should have remembered to create a proper changelog; thankfully they aren't really major edits but here's the difference:

headerinclude
I have added

?ver=1400

after the standard javascript files as I only found out quite recently this was probably quite important, especially in light of some of the recent changes to the MyBB 1.4 series.

The 'correct' and 'new' code is below:

<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/prototype.js?ver=1400"></script>
<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/general.js?ver=1400"></script>
<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/popup_menu.js?ver=1400"></script>

vbnavbar.css
The change is that

display:block;

instead of

display:visible;

. This was also inherited from the original and it's only after running the CSS through the validator that I found out about the problem. I haven't personally noticed any difference myself after the change, testing in IE and FF, but I really should have run this through the validator before posting it anyway.

* html .popup_menu ul li a {
display: block;
width: 100%;
}

Hope this helps!

Just to let everybody know, I have tested the vbnavbar code (with the modifications I, and flick, did) on IE (6 + 7 + Beta 8), Firefox 3.02 - 3.05(current) and Google Chrome (release - NOT beta) and everything seems to work fine except for:
1) Chrome (the problem is a MyBB problem - not the vbnavbar, but please note): You'll, probbly need to check the settings for your cookies. Please look at, my, post: http://community.mybboard.net/thread-43111.html
2) IE 8 (beta, but it will remain for future betas and release): MyBB (and the vbnavbar for that) appear different then in any other browser (there are too many differences to write in here). The solution is to work in "Compatibly mode" - IE prompt that this mode is best for viewing the forum. This is a CSS problem and in the near future I should be getting a full convention table/document for the IE 8 from Microsoft (I'm a partner of them).


Ori...