[F] editpost.php issue with closed forums [R]

[Matt]

It comes down to what should be allowed in a closed forum. Is it every permission for every group that isn't allowed, or should an admin have limited powers still??

[Troll]

By definition, the admin should have powers in every situation on a Bulletin Board. It's the system admin, it's his system, he must have the permissions to do what he wants, else, who will be able to do it ? Chuck Norris ?

The script is not supposed to say "No" to the admin...

[brad-t]

Have to agree. Let's say I move something to the closed forum, and then want to edit something offensive out ... what's my option?

[Tomm M]

Have to agree. Let's say I move something to the closed forum, and then want to edit something offensive out ... what's my option?

Quick edit it seems...

In which case, the error_no_permission being thrown on full edit will be the thing that needs changed...

[Ryan Gordon]

I'll make the change in editpost.php

[Tomm M]

@Ryan, I've prepared the fix Michael suggested and will commit it if you haven't already fixed this on your end.

[User 2877]

Hey...why not alter the error_no_permission function so that it just returns for admins...imho that solves all the issues at one time for admins not having permission and it also doesn't require changes all over the files to exclude admins.

Just a thought.

[Tomm M]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

With regards,
MyBB Group

[Troll]

Ok

Can we get the snippet of the finally chosen fix ?

[Tomm M]

In editpost.php, find:

if($forum['open'] == 0 || $mybb->user['suspendposting'] == 1)
{
	error_no_permission();
}

and replace it with

if(($forum['open'] == 0 || $mybb->user['suspendposting'] == 1)) && $mybb->usergroup['cancp'] != 1)
{
	error_no_permission();
}

Doing this will allow Administrators access to full edit.