Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Small typo?
#1
In class.core.php

line 134

$protected = array("_GET", "_POST", "_SERVER", "_COOKIE", "_FILES", "_SERVER", "_ENV", "GLOBALS");

should be

$protected = array("_GET", "_POST", "_SERVER", "_COOKIE", "_FILES", "_ENV", "GLOBALS");


???
#2
Why shouldn't _SERVER be protected? It's not human input.
#3
(2009-06-10, 07:33 AM)CraKteR Wrote: Why shouldn't _SERVER be protected?

It's listed twice in the list...?
#4
Ah sorry I gotta be tired.
#5
(2009-06-10, 07:42 AM)CraKteR Wrote: Ah sorry I gotta be tired.

Me too - I had to double check... Toungue
#6
LOL you better be off to bed then Wink any whys it it meant to be in there two times as i do not think so that's why i posted it here.
#7
Woah haha I didn't see it the first time I read it too. Oh well, it's minor and it's only a few extra bytes of data.
#8
This is a redundant fix because it actually doesn't cause any bugs. It should be modified for MyBB 1.6, but not MyBB 1.4.7. I don't want to touch code in class_core.php, past the version number, if we don't have to.


Forum Jump:


Users browsing this thread: 1 Guest(s)