Small typo?

[ChrisR]

In class.core.php

line 134

$protected = array("_GET", "_POST", "_SERVER", "_COOKIE", "_FILES", "_SERVER", "_ENV", "GLOBALS");

should be

$protected = array("_GET", "_POST", "_SERVER", "_COOKIE", "_FILES", "_ENV", "GLOBALS");

???

[Martin M.]

Why shouldn't _SERVER be protected? It's not human input.

[Tomm M]

Why shouldn't _SERVER be protected?

It's listed twice in the list...?

[Martin M.]

Ah sorry I gotta be tired.

[Tomm M]

Ah sorry I gotta be tired.

Me too - I had to double check...

[ChrisR]

LOL you better be off to bed then any whys it it meant to be in there two times as i do not think so that's why i posted it here.

[hamster]

Woah haha I didn't see it the first time I read it too. Oh well, it's minor and it's only a few extra bytes of data.

[Ryan Gordon]

This is a redundant fix because it actually doesn't cause any bugs. It should be modified for MyBB 1.6, but not MyBB 1.4.7. I don't want to touch code in class_core.php, past the version number, if we don't have to.