MyBB Community Forums

Feel free to list all of them here please.

var pm_notice = $("#content").find("div#pm_notice");

var expanders = $("div.expcolimage img.expander");

mark_read_imgs = $("img.ajax_mark_read");

		$('div.trow_selected').each(function() {
			$(this).removeClass('trow_selected');
		});

		$('td.trow_selected').each(function() {
			$(this).removeClass('trow_selected');
		});

var post = element.parents('div.post_content');

Also, for these ones:

selectRow.css('display', "table-row");

thread.children('td').addClass('trow_selected');

thread.children('td').removeClass('trow_selected');

var thread = element.parents('tr');

Just seems limiting.


I'm sure all of this can't be changed (The td things mostly) but all of them would help designers. I just skipped most of the ones that really wouldn't effect anything, such as jGrowl selectors.

If I find any others I'll add them in.

Can agree with Eric here.

Thanks, moving this to issues.

Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/700

Thanks for contributing to MyBB!

Regards,
The MyBB Group

Should I edit the selectors in inline_moderation.js that target specific elements as well? This would require adding classes to some of the table rows and things but afaik would allow people to create completely table-less themes if they want. Just want to know before I do anything with it.

You can suggest whatever you want. I currently have my time very limited but within a week or so I'll be able to go through some issues, including this one.

Alright, well we did already take care of these issues here:

https://github.com/mybb/mybb/pull/707
https://github.com/mybb/mybb/pull/709

So I was looking at replacing the stuff like:

var thread = element.parents('tr');

With something like:

var thread = element.parents('.threadListRow');

So that the moderation doesn't rely on things being built with tables. I just want to know if this would be accepted before doing it, as long as it's done right of course. And also if it fit in with this suggestion, or if it should be it's own separate thread/branch.

As long as it is done right most probably. Your las example may as well fit here.

I agree with the tr thing btw, I found myself having issues with my custom theme which uses no tables for the first post layout.