Thread Rating:
  • 3 Vote(s) - 3.67 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[For 1.8] Many New Posts
#11
I'm not 100% sure if this line is ok in that PHP version:
 
if($userlastview && $timelimit > time()) {

I really would say to use the constant TIME_NOW instead of using time() in the if statement. If that doesn't fix it, I'll look more into it.

@jung30: You really should use the _activate function to add templates instead of the_install function because if someone needs to disable the plugin by deactivating it and then wants to reactivate it, they will need to uninstall it first with how your code is written. _install should be reserved for database changes. Since your plugin doesn't add any database fields or tables, it is not necessary to use the _is_installed function.
Reply
#12
(2014-10-24, 09:52 PM)dragonexpert Wrote: I'm not 100% sure if this line is ok in that PHP version:

 
if($userlastview && $timelimit > time()) {

I really would say to use the constant TIME_NOW instead of using time() in the if statement.  If that doesn't fix it, I'll look more into it.

@jung3o: You really should use the _activate function to add templates instead of the_install function because if someone needs to disable the plugin by deactivating it and then wants to reactivate it, they will need to uninstall it first with how your code is written.  _install should be reserved for database changes.  Since your plugin doesn't add any database fields or tables, it is not necessary to use the _is_installed function.

I dont see why it would interfere with new php version... but, I changed it as you suggested

and removed install function
http://community.mybb.com/mods.php?actio...71&bid=457

changes
https://github.com/jung3o/Many-New-Posts...39c1761f7d
Reply
#13
It's no big deal, I don't want to be a bother. Thanks for working on it though!

Here's what I get in Firefox, I just updated:

Content Encoding Error

The page you are trying to view cannot be shown because it uses an invalid or unsupported form of compression.

I still get the same errors in IE and Chrome as I did before. It's fine on the index, but I can't view any actual forums.

Again, don't go to any trouble on my account. I do appreciate it though. Smile
Reply
#14
Does the issue persist if you temporarily disable the plugin?
Reply
#15
No, if I disable it, business as usual. Everything goes back to functioning as it should.
Reply


Forum Jump:


Users browsing this thread: 3 Guest(s)