Inline Downloads 1.0

[x-Treme]

The {$download_table} remains in the newthread template when I uninstall. I have to manually remove it.
If not, if I re-install it, the table appears twice.

[DamYan]

The {$download_table} remains in the newthread template when I uninstall. I have to manually remove it.
If not, if I re-install it, the table appears twice.

Easy to fix.

In download_system.php file search for:

function download_system_deactivate()
{
	require MYBB_ROOT.'/inc/adminfunctions_templates.php';
	find_replace_templatesets("postbit", '#'.preg_quote("{\$post['download_system']}").'#', '');
	find_replace_templatesets("postbit_classic", '#'.preg_quote("{\$post['download_system']}").'#', '');
	find_replace_templatesets("newthread", '#'.preg_quote("{\$download_table}").'#', '');
	find_replace_templatesets("editpost", '#'.preg_quote("{\$download_table}").'#', '');
}

Replace with

function download_system_deactivate()
{
	require MYBB_ROOT.'/inc/adminfunctions_templates.php';
	find_replace_templatesets("postbit", '#'.preg_quote("{\$post['download_system']}").'#', '',0);
	find_replace_templatesets("postbit_classic", '#'.preg_quote("{\$post['download_system']}").'#', '',0);
	find_replace_templatesets("newthread", '#'.preg_quote("{\$download_table}").'#', '',0);
	find_replace_templatesets("editpost", '#'.preg_quote("{\$download_table}").'#', '',0);
}

[StefanT]

I don't think it solves the problem because it has nothing to do with the regex. But I will test it.

[DamYan]

I don't think it solves the problem because it has nothing to do with the regex. But I will test it.

What with your tests?

[StefanT]

Oh... I will test it soon.

[StefanT]

What with your tests?

I had some time to test and I think you hint was really good. Thank you!

New Version: http://mods.mybboard.net/view/inline-downloads
https://github.com/Stefan-ST/MyBB-Inline-Downloads

[aglioeolio]

What with your tests?

I had some time to test and I think you hint was really good. Thank you!

New Version: http://mods.mybboard.net/view/inline-downloads
Bug-Tracker, SVN and Web-SVN

Thanks a lot

[alirex]

MyBB has experienced an internal SQL error and cannot continue.

SQL Error:
1366 - Incorrect integer value: '' for column 'last' at row 1
Query:
INSERT INTO mybb_downloads (tid,aid,link,title,version,preview,author,author_website,author_original,license,last,guestdl,own,downloads) VALUES ('0','0','http://www.something.info/zapper.zip',' 2.1.X Uploads','2.1.X','','','','','','','1','1','0')

this error is coming when i tried to check the mod in localhost

[Diogo Parrinha]

For those experiencing problems with this plugin and in case you do not want to wait for a fixed version you can try XThreads available here:
http://mybbhacks.zingaburga.com/index.php

It has a very neat attachments system and you can easily create a downloads section for your website.

[Maechlis]

Very nice plugin.

Some remarks.

1) For English language downloads.lang.php should read

]$l['ds_title'] = 'Title';

(not "Titel")

2) I can not understand what is the flag "Mark as newest version?" for, from the user's point of view. I have not succeeded in finding out whether it is influencing something.

3) It would be nice to have the field "Version" as optional, not mandatory. Also, adding the version number to the thread title is IMHO an excessive feature. At least it should be optional.

4) It makes sense to have the "Title" field independent from the thread title.

5) If we permit inline downloads in some forum, then all threads in this forum require to have inline downloads. Otherwise we can not create the thread. This is very inconvenient.