MyBB Community Forums

Full Version: DVZ Secure Content 1.2
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2 3 4 5 6 7 8 9 10
Version 1.1.6
  • Updated for compatibility with [img] changes in MyBB 1.8.23
  • Fixed avatar URL length check in Proxy avatar URLs
  • Minor improvements
I think there is a small bug. When you don't want to use a proxy, you do self::settings('proxy'). It will alway return something (0 or 1), so it's alway true.
You may change that to self::settings('proxy')===1 in all occurences of your test
(2020-11-01, 02:51 PM)Crazycat Wrote: [ -> ]I think there is a small bug. When you don't want to use a proxy, you do self::settings('proxy'). It will alway return something (0 or 1), so it's alway true.
You may change that to self::settings('proxy')===1 in all occurences of your test

Do you see unexpected behavior?

if (self::settings('proxy')) should result in a loose comparison (with "0" or "1"): https://www.php.net/manual/en/types.comparisons.php
Sorry, I checked too fast and made a mistake in the real trouble in your plugin.
There is a trouble when the plugin is activated without changing anything to its default settings and the remote avatar is allowed,
I'll find where is exactly the problem, seems like you don't check if dvz_sc_proxy is set to 1 and alway use the values of dvz_sc_proxy_avatars.
Version 1.2
  • Added Proxy hostname exceptions to allow specified domains to bypass the proxy when using HTTPS
  • Added enforcement of Block non-HTTPS avatars in the Admin CP
  • Changed behavior of Filter non-HTTPS MyCode images to apply regardless of Image proxy setting
  • Added data-original-url attribute to <img> tags
  • Fixed unintended proxying when Image proxy was disabled
  • Fixed behavior when setting avatar by Gravatar email
  • Improved compatibility with MyCode in 3rd party plugins
  • Minor improvements

Upgrading: Overwrite files and re-activate the plugin.
Great, thank you!
@Devilshakerz, thank you for the update.

Just a quick question for you, in the future within this plugin could there be away where if someone posts a http : //  website url inside a post that somehow your plugin could interfece and redirect the url through https or would this be to difficult to add? Besides this is still a beautiful plugin to have on all mybb forums.
Pages: 1 2 3 4 5 6 7 8 9 10