A
preview version of MyBB 1.8.20 expected to address several minor issues is now ready for public testing.
During this phase we welcome board administrators, developers and our Community to verify installation, upgrading, compatibility, and general stability using test and/or staging environments before an official upgrade is released and applied to live boards.
Download from GitHub: https://github.com/mybb/mybb/releases/ta...1820_build
* Non-production use only: Pre-release versions, including upgrades to/from/between them, are generally not supported. Test packages may contain errors that may be difficult to recover from on active boards.
* Pre-release: The software can be installed or upgraded by placing/overwriting files from the package. The final release may include further modifications including those addressing security issues, and separate update packages for use with the previous version.
* Dynamic build: The provided code is attached to a repository tag that may be updated when additional public updates are pushed.
Resolved Issues: MyBB 1.8.20 Milestone
Comment: This release updates the jQuery version used to jQuery 3.0.0. Whilst not the most recent version (that jump will happen in 1.8.21), there is a chance that some custom JS may break - please test and raise any issues in the forums so we can find fixes!
Testing focus:
Please report suspected issues related to this update here or on our
Discord in
#18-development.
Go to
mybb.com/security to report possible security concerns or to learn more about security research at MyBB.
If you would like to contribute to the Project,
Get Involved.
Thanks,
The MyBB Team
Just checking this is only a file-change update, since the install folder hasn't been updated.
Is it just my test forum or have 2 new queries come from somewhere:
SELECT replyto FROM test_posts WHERE visible = 0
SELECT COUNT(aid) AS unapprovedattachments FROM test_attachments WHERE visible=0
Save me having to look for them, where are they located?
OK, scrub the query question. Found it here:
https://github.com/mybb/mybb/pull/3488/files
Typo when a thread is waiting for approval
"
and aiting Moderation: 1 unapproved thread."
Narrowed down the error to rogue code on line 783 - global.php
$moderation_queue = substr_replace($moderation_queue, ' '.$lang->and.' ', strrpos($moderation_queue, $lang->comma), strlen($lang->comma));
I can fresh install, but is anyone else having problems dropping the files into an existing 1.8.19 forum (using 1.8.19 database).
I'm guessing there must be a change somewhere in the database.
The remove attachment works well when editing an existing post... but if you add an attachment to a new thread (or new post in advanced mode) and then change your mind and press the remove button before posting, it doesn't remove the attachment Ajax (although it does actually remove it from the post - it doesn't look like its been removed).
Hard to explain. You'll need to try it to see what I mean lol.
From my test, everything works fine so far.
But i think this should be posted inside 1.8 development where 1.8.19 and 1.8.18 pre-release builds are posted.
Quote:The remove attachment works well when editing an existing post... but if you add an attachment to a new thread (or new post in advanced mode) and then change your mind and press the remove button before posting, it doesn't remove the attachment Ajax (although it does actually remove it from the post - it doesn't look like its been removed).
Please, can you describe better how to reproduce?
(2019-01-24, 01:15 PM)codedude Wrote: [ -> ]From my test, everything works fine so far.
But i think this should be posted inside 1.8 development where 1.8.19 and 1.8.18 pre-release builds are posted.
Good catch, I messed that up last night. Thanks!
@woostar I saw your issue on GitHub for the wording problem, thanks. We'll work on a patch for that before the full release. I'll have a look at your other comments too and see what we can do. Thanks for testing!
(2019-01-24, 04:47 PM)Eldenroot Wrote: [ -> ]Quote:The remove attachment works well when editing an existing post... but if you add an attachment to a new thread (or new post in advanced mode) and then change your mind and press the remove button before posting, it doesn't remove the attachment Ajax (although it does actually remove it from the post - it doesn't look like its been removed).
Please, can you describe better how to reproduce?
1. In a forum - Press 'Post Thread' button (which will take you to the post editor).
2. Under 'New attachment', press the 'Choose Files' button.
3. Select a file
4. Press 'Add Attachment'
*The attachment is now shown under 'Attachments'*
5. Press 'Remove' next to the file you've just selected (assume you selected the wrong file and want to pick a different file).
Even though 'Remove' is pressed, the attachment is still shown under 'Attachments'.
The attachment doesn't look like its been removed (although when you submit the post, the file isn't attached).
This also happens when you press 'New Post' in a thread (instead of using the quick reply).
(2019-01-24, 06:53 PM)woostar Wrote: [ -> ] (2019-01-24, 04:47 PM)Eldenroot Wrote: [ -> ]Quote:The remove attachment works well when editing an existing post... but if you add an attachment to a new thread (or new post in advanced mode) and then change your mind and press the remove button before posting, it doesn't remove the attachment Ajax (although it does actually remove it from the post - it doesn't look like its been removed).
Please, can you describe better how to reproduce?
1. In a forum - Press 'Post Thread' button (which will take you to the post editor).
2. Under 'New attachment', press the 'Choose Files' button.
3. Select a file
4. Press 'Add Attachment'
*The attachment is now shown under 'Attachments'*
5. Press 'Remove' next to the file you've just selected (assume you selected the wrong file and want to pick a different file).
Even though 'Remove' is pressed, the attachment is still shown under 'Attachments'.
The attachment doesn't look like its been removed (although when you submit the post, the file isn't attached).
This also happens when you press 'New Post' in a thread (instead of using the quick reply).
Unfortunately I can confirm this issue, but this is really weird, it was fine when I was testing this PR...
You can upload an attachment, but when you click on "Remove" button -> popup is displayed but when you click on "Yes", attachment is still there... you have to refresh your page to view changes (attachment is deleted, but page must be refreshed manualy). AJAX refresh is not working somehow.
(Tested on fresh install).
Thanks guys, I'll have a look into this issue too and see if it's anything obvious.
About two new queries - they come from a new feature - moderation notice IIRC
This is what console log said into fresh install into thread creation.
jQuery.Deferred exception: a.indexOf is not a function r.fn.load@http://whiteneo.es/jscripts/jquery.js?ver=1820:4:18688
K@http://whiteneo.es/jscripts/sceditor/jquery.sceditor.bbcode.min.js?ver=1805:2:1915
o@http://whiteneo.es/jscripts/sceditor/jquery.sceditor.bbcode.min.js?ver=1805:2:24225
d</a.fn.sceditor/<@http://whiteneo.es/jscripts/sceditor/jquery.sceditor.bbcode.min.js?ver=1805:2:820
each@http://whiteneo.es/jscripts/jquery.js?ver=1820:2:2811
each@http://whiteneo.es/jscripts/jquery.js?ver=1820:2:1001
d</a.fn.sceditor@http://whiteneo.es/jscripts/sceditor/jquery.sceditor.bbcode.min.js?ver=1805:2:655
@http://whiteneo.es/newthread.php?fid=2:432:16
j@http://whiteneo.es/jscripts/jquery.js?ver=1820:2:29586
g/</k<@http://whiteneo.es/jscripts/jquery.js?ver=1820:2:29902
undefined
Even attachments does not work by ajax i think is due this error because it appears like a post entire method not ajax, and when press Remove button do nothing at all.
Even i have tried before an upgrade and same happens so i have make a fresh install and i am testing but this issue appears into console log when you try to create a new thread and do any stuff in there.
I have not tried other parts yet because i do not know what are the new addons or where are they so i am focused into some basic mybb functions like create threads, posts, etc.