2009-01-30, 02:29 AM
And there we are, back to the beginning of the circle.
You are already recursing through the forums... that's exactly what the build_forumbits function is doing, recurse through forums. It's a recursive function by design. Recursion is already done to find the lastpost of a forum or its subforums. What my patch does is use the information obtained in this recursion a little differently.
And I don't think it's fair to nix this just because some very big forum chooses to use quadrillions of subforums. This issue is an annoyance to all forums, especially the smaller ones that don't have thousands of users online at any time of the day. In a forum where not all bulbs are always on anyway because someone always posts something new somewhere, it's all the more important to have a proper lightbulb logic.
You can shy away from this problem forever, other forum systems don't and they even go a step further by offering combined status icons that show current forum and subforum status in one image (which is what I also do in my plugin). I do not know wether other forums implementation is perfect and I also do not know wether my own implementation is perfect, but I do know that the current implementation of MyBB is just wrong, blatantly obviously so.
You are already recursing through the forums... that's exactly what the build_forumbits function is doing, recurse through forums. It's a recursive function by design. Recursion is already done to find the lastpost of a forum or its subforums. What my patch does is use the information obtained in this recursion a little differently.
And I don't think it's fair to nix this just because some very big forum chooses to use quadrillions of subforums. This issue is an annoyance to all forums, especially the smaller ones that don't have thousands of users online at any time of the day. In a forum where not all bulbs are always on anyway because someone always posts something new somewhere, it's all the more important to have a proper lightbulb logic.
You can shy away from this problem forever, other forum systems don't and they even go a step further by offering combined status icons that show current forum and subforum status in one image (which is what I also do in my plugin). I do not know wether other forums implementation is perfect and I also do not know wether my own implementation is perfect, but I do know that the current implementation of MyBB is just wrong, blatantly obviously so.