Posts: 792
Threads: 47
Joined: Aug 2011
This is a perfect example why the plugin release system needs something done (
http://community.mybb.com/thread-132303.html ). Staff here have confirmed that plugins are checked before they're released. How was this released with it having the issues that paveman just pointed out ?
Posts: 13,647
Threads: 220
Joined: May 2010
Reputation:
550
(2013-01-14, 08:20 PM)Frank.Barry Wrote: This is a perfect example why the plugin release system needs something done ( http://community.mybb.com/thread-132303.html ). Staff here have confirmed that plugins are checked before they're released. How was this released with it having the issues that paveman just pointed out ?
They're checked for malicious code and obvious vulnerabilities, not extensively tested for every possible security issue. It's not our job to make sure every plugin is secure. Complain to the developer, not to us.
No longer involved in the MyBB project.
Posts: 13,647
Threads: 220
Joined: May 2010
Reputation:
550
(2013-01-14, 08:33 PM)mohdows Wrote: The are no malicious code and obvious vulnerabilities ; its safe
http://community.mybb.com/thread-108549-...#pid961500
No longer involved in the MyBB project.
Posts: 792
Threads: 47
Joined: Aug 2011
2013-01-14, 08:53 PM
(This post was last modified: 2013-01-14, 08:57 PM by Frank.Barry.)
(2013-01-14, 08:29 PM)Nathan Malcolm Wrote: (2013-01-14, 08:20 PM)Frank.Barry Wrote: This is a perfect example why the plugin release system needs something done ( http://community.mybb.com/thread-132303.html ). Staff here have confirmed that plugins are checked before they're released. How was this released with it having the issues that paveman just pointed out ?
They're checked for malicious code and obvious vulnerabilities, not extensively tested for every possible security issue. It's not our job to make sure every plugin is secure. Complain to the developer, not to us.
Im not complaining. Im just trying to push for better ways for this stuff to be released. I know its just not as simple as saying "ok we'll do it like this", and thats it solved. But surely theres a better method of validation before a plugin is released. I know this particular plugin is not so much a security issue but in all honesty (With respect to the developer) this shouldn't have been released from the word go.
When it was first posted I download it to have a look at the code and noticed that the query being used was hardcoded to disallow threads from specific forums to be displayed. Obviously this plugin was created for a specific forum. Surely when staff are checking for malicious code an sql query is priority. Although this is not malicious code it clearly wasn't going to work correctly on other forums.
(2013-01-13, 09:41 PM)mohdows Wrote: ok , let's waiting others ideas
(2013-01-13, 09:24 PM)Frank.Barry Wrote: 2. Dont block specific forums in your query and release the plugin to the public, thats just ridicules.
done
He even confirmed that he fixed that issue, which he clearly didn't, as the query is still the same.