MyBB Community Forums

Full Version: MyBB FancyBox v1.1.2
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2 3 4 5 6 7 8 9 10
OK, please test version v0.4 - https://community.mybb.com/mods.php?acti...3&bid=3296

Changelog:
- added support for images in posts
- added support for subfolder MyBB installations (MyBB Asset URL)
- small code changes and improvements

Thank you @Wildcard and @8guawong!
(2018-08-07, 12:32 PM)8guawong Wrote: [ -> ]i don't really know how to use github Sad

It was just a suggestion.

You should totally make a GitHub account and download GitHub Desktop (free software). Then you can create a test repo and learn how to GitHub without all of the pressure. It really isn't as hard as it seems.
(2018-08-07, 03:51 PM)Eldenroot Wrote: [ -> ]OK, please test version v0.4 - https://community.mybb.com/mods.php?acti...3&bid=3296

Changelog:
- added support for images in posts
- added support for subfolder MyBB installations (MyBB Asset URL)
- small code changes and improvements

Thank you @Wildcard and @8guawong!

something is wrong with
https://github.com/mybbgroup/MyBB_Fancyb...x.php#L133

the postbit_attachments_images_image template should look like

<a target='_blank' data-fancybox="data-{$attachment['pid']}" data-type='image' href="attachment.php?aid={$attachment['aid']}"><img src="attachment.php?aid={$attachment['aid']}" class="attachment" alt="" title="{$lang->postbit_attachment_filename} {$attachment['filename']}
{$lang->postbit_attachment_size} {$attachment['filesize']}
{$attachdate}" />&nbsp;&nbsp;&nbsp;{$attachment['filename']}
{$lang->postbit_attachment_size} {$attachment['filesize']}
{$attachdate}" /></a>&nbsp;&nbsp;&nbsp;

currently with 0.4
https://www.blackmarke7.org/mybbtest/sho...pid=4#pid4
you can check out what is wrong

(2018-08-07, 03:59 PM)Wildcard Wrote: [ -> ]
(2018-08-07, 12:32 PM)8guawong Wrote: [ -> ]i don't really know how to use github Sad

It was just a suggestion.

You should totally make a GitHub account and download GitHub Desktop (free software). Then you can create a test repo and learn how to GitHub without all of the pressure. It really isn't as hard as it seems.

ok maybe someday Smile
Nope, please check "plugin activation" part, not deactivation

https://github.com/mybbgroup/MyBB_Fancyb...x.php#L129
(2018-08-07, 04:47 PM)Eldenroot Wrote: [ -> ]Nope, please check "plugin activation" part, not deactivation

https://github.com/mybbgroup/MyBB_Fancyb...x.php#L129

umm i donno i probably looked at the wrong place
but still with v0.4
there is something wrong with attachment that is shown as full size image as shown here

https://www.blackmarke7.org/mybbtest/sho...pid=4#pid4
Sorry but I cannot reproduce... did you check all affected templates and hard refresh of your web browser (ctrl+f5)?
(2018-08-07, 05:53 PM)Eldenroot Wrote: [ -> ]Sorry but I cannot reproduce... did you check all affected templates and hard refresh of your web browser (ctrl+f5)?

yes i have
i've sent you a test account in pm
This plugin works (and supports) only thumbnails in attachment box  + images in posts... if you wanna add a support for full-size images in an attachment box, you have to make some more template edits... sorry, but I wont add support for that, not in a close future, because it seems to be quite difficult and I dont see why anyone wanna use full size images in attachment box and use FancyBox together... I created this plugin to open thumbnails in a nice modal window in the same window, not to open full size image - it doesnt make any sense to me, srry
(2018-08-07, 06:39 PM)Eldenroot Wrote: [ -> ]This plugin works (and supports) only thumbnails in attachment box  + images in posts... if you wanna add a support for full-size images in an attachment box, you have to make some more template edits... sorry, but I wont add support for that, not in a close future, because it seems to be quite difficult and I dont see why anyone wanna use full size images in attachment box and use FancyBox together... I created this plugin to open thumbnails in a nice modal window in the same window, not to open full size image - it doesnt make any sense to me, srry

errr ok its your plugin.....but
https://github.com/mybbgroup/MyBB_Fancyb...x.php#L121
https://github.com/mybbgroup/MyBB_Fancyb...x.php#L133

shows that you tried to add support for it just you did it wrong
and its not difficult i already showed you numerous time on how to do it

https://community.mybb.com/thread-219143...pid1311111
https://community.mybb.com/thread-219143...pid1311149

if you are not going to add it then i suggest remove both of those lines
(2018-08-07, 06:45 PM)8guawong Wrote: [ -> ]
(2018-08-07, 06:39 PM)Eldenroot Wrote: [ -> ]This plugin works (and supports) only thumbnails in attachment box  + images in posts... if you wanna add a support for full-size images in an attachment box, you have to make some more template edits... sorry, but I wont add support for that, not in a close future, because it seems to be quite difficult and I dont see why anyone wanna use full size images in attachment box and use FancyBox together... I created this plugin to open thumbnails in a nice modal window in the same window, not to open full size image - it doesnt make any sense to me, srry

errr ok its your plugin.....but
https://github.com/mybbgroup/MyBB_Fancyb...x.php#L121
https://github.com/mybbgroup/MyBB_Fancyb...x.php#L133

shows that you tried to add support for it just you did it wrong
and its not difficult i already showed you numerous time on how to do it

https://community.mybb.com/thread-219143...pid1311111
https://community.mybb.com/thread-219143...pid1311149

if you are not going to add it then i suggest remove both of those lines

Here's an idea for you @8guawong...

If you want a plugin to display full-size images, why not create one of your own? 

Then put the plugin up in the Plugin Releases forum and see how it goes.
Pages: 1 2 3 4 5 6 7 8 9 10