We misunderstood, anyway use this plugin as it is or create a pull request with proposed code changes via GitHub or wait - I am really busy, MyBB is my hobby, I have a wife, family and a full-time job. I cannot cover all situations in one day after the first public release...
EDIT: your reply is not correct, why did you point to plugin deactivation function? You wanted to add support for loop browsing of all images in posts, I added that today for you, are you talking about any other feature request, because I dont follow you... sorry.
EDIT2: My and your code is same, I just added small changes into "title", but it has no effect on a plugin functionality...
(2018-08-07, 07:02 PM)Serpius Wrote: [ -> ] (2018-08-07, 06:45 PM)8guawong Wrote: [ -> ] (2018-08-07, 06:39 PM)Eldenroot Wrote: [ -> ]This plugin works (and supports) only thumbnails in attachment box + images in posts... if you wanna add a support for full-size images in an attachment box, you have to make some more template edits... sorry, but I wont add support for that, not in a close future, because it seems to be quite difficult and I dont see why anyone wanna use full size images in attachment box and use FancyBox together... I created this plugin to open thumbnails in a nice modal window in the same window, not to open full size image - it doesnt make any sense to me, srry
errr ok its your plugin.....but
https://github.com/mybbgroup/MyBB_Fancyb...x.php#L121
https://github.com/mybbgroup/MyBB_Fancyb...x.php#L133
shows that you tried to add support for it just you did it wrong
and its not difficult i already showed you numerous time on how to do it
https://community.mybb.com/thread-219143...pid1311111
https://community.mybb.com/thread-219143...pid1311149
if you are not going to add it then i suggest remove both of those lines
Here's an idea for you @8guawong...
If you want a plugin to display full-size images, why not create one of your own?
Then put the plugin up in the Plugin Releases forum and see how it goes.
i've already stated here
https://community.mybb.com/thread-219143...pid1311099
that i'm using something else already
and since i'm crap in coding i won't be releasing any of my crap code to the public anytime soon XD
(2018-08-07, 07:21 PM)Eldenroot Wrote: [ -> ]We misunderstood, anyway use this plugin as it is or create a pull request with proposed code changes via GitHub or wait - I am really busy, MyBB is my hobby, I have a wife, family and a full-time job. I cannot cover all situations in one day after the first public release...
EDIT: your reply is not correct, why did you point to plugin deactivation function? You wanted to add support for loop browsing of all images in posts, I added that today for you, are you talking about any other feature request, because I dont follow you... sorry.
EDIT2: My and your code is same, I just added small changes into "title", but it has no effect on a plugin functionality...
sok buddy! maybe we have some communication barrier! maybe some1 will come along that will make you understand what i'm trying to tell you =)
I released a new version today (v0.5)
Changelog:
* FancyBox library updated to v3.4.0 (29/08/2018) - a lot of bug fixes and improvements
* fix CSS for images
I recommend to update, there are a lot of fixes in JS library
New version 0.6 was released! This update brings a support for custom languages including phrases located in JS files. Moreover we added better way how template modifications are handled during install/uninstall process. Also FancyBox library was updated to the last stable release v3.4.1 which brings new features and bug fixes.
How to update? If you are using v0.5 or older, please deactivate and uninstall -> copy new files and overwrite the old ones -> install again.
Thank you @Wildcard for your help and contribution!
https://community.mybb.com/mods.php?acti...w&pid=1153
Hi,
After update mybb 1.8.15 to 1.8.19 and fancybox 0.5 to 0.6 fancybox doesn't work - img always will be opened in separate tab. It's no difference between attached or included Images. Language files I had copied to german Folders …
I had reinstalled the 0.5, and all is ok.
… sorry, it was my mistake. After Update I had forgotten to switch all plugins on. 0.5 work's during all Plugins are off, and so I didn't realise the reason.
Anyway I recommend to you (and to everyone) to use v0.6.
I was about to reply and say it is working fine for me
I highly recommend this plugin, as well. And not because I helped a little, either. It is the other way around: I helped because this is a worthy project and when I have time I will be using this on some of my forums.
Great work as always, Eldenroot.
(2018-09-21, 08:27 PM)Wildcard Wrote: [ -> ]I was about to reply and say it is working fine for me
I highly recommend this plugin, as well. And not because I helped a little, either. It is the other way around: I helped because this is a worthy project and when I have time I will be using this on some of my forums.
Great work as always, Eldenroot.
Thank you for your kind words. I just released v0.7 which brings a lot of useful improvements and bug fixes.
I would like to add a few idead in future, we will see
Hello,
thanks for your good work. We'll change the picture plugin highslide to fancybox in next time because fancybox is very good too and highslide isn't developed since many years …
one notice - in fancybox 0.5 we could move pictures to left and right too, but in 0.6 and 0.7 it's only possibile up and down. :-(