Thread Rating:
  • 12 Vote(s) - 4.08 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[For 1.6] MentionMe 2.3.3 (for MyAlerts 1.05)
(2016-12-09, 12:17 AM)Dark Neo Wrote: I have not had time to test it thoroughly yet, everything works fine, but only in quick response

Okay thanks for the report. I'll do a little testing on my own.
[retired]
Do not worry, I will see to continue reviewing to contribute something, so far I have seen this:

Downloading the latest revision here from MyAlerts, I have seen that it causes many errors and you can never install your plugin and its github version with MyAlerts 2.0.2 the last file sent here.

I will check it with the files that I have modified from MyAlerts and the github version of Euan T. to see how it goes.

Anyway I can do if you want some minor contribution to this plugin, I have one of mentions, but it is a compilation of ideas and nothing that works at all, but it goes well for my purposes xD.

I will try to make a fork of your project with my github account and I will work on some changes for the things that can help, I know that will be little, but to have if I contribute at least in some way. I hope I can contribute something because this is a very useful plugin for all, I use it from 1.6.x and made it work in 1.8.x from the beginning since we have always used it on my site.

Thanks for all your effort and I use the Google translator better because I see that I write many times without meaning, hahaha.

Sorry about my bad english i use this time Google Translator to see if helps to express more clear my ideas.
The only infinite thing is the universe and human stupidity, but the universe is not for sure

Plugins 1.6.x

Plugins 1.8.x

(2016-12-09, 03:46 AM)Dark Neo Wrote: Downloading the latest revision here from MyAlerts, I have seen that it causes many errors and you can never install your plugin and its github version with MyAlerts 2.0.2 the last file sent here.

I will check it with the files that I have modified from MyAlerts and the github version of Euan T. to see how it goes.

So the plugin only works with the version of MyAlerts that is on GitHub and not the version on the mods site?

(2016-12-09, 03:46 AM)Dark Neo Wrote: Anyway I can do if you want some minor contribution to this plugin, I have one of mentions, but it is a compilation of ideas and nothing that works at all, but it goes well for my purposes xD.

I will try to make a fork of your project with my github account and I will work on some changes for the things that can help, I know that will be little, but to have if I contribute at least in some way. I hope I can contribute something because this is a very useful plugin for all, I use it from 1.6.x and made it work in 1.8.x from the beginning since we have always used it on my site.

Thanks. Any help is appreciated. To make things simpler, create an issue for whatever problem you've found and then wait for me to review before starting a pull request. That way if I feel like something needs to change you won't waste any effort.

(2016-12-09, 03:46 AM)Dark Neo Wrote: Thanks for all your effort and I use the Google translator better because I see that I write many times without meaning, hahaha.

You're very welcome. Thank you for testing. That is an essential part of development.

(2016-12-09, 03:46 AM)Dark Neo Wrote: Sorry about my bad english i use this time Google Translator to see if helps to express more clear my ideas.

No worries, my friend. I have trouble understanding you, but we can work around it.
[retired]
Nope MyAlerts can not be integrated.

Mentionme works anyway fine as plugin on every part, my theme and database are the problem to show errors with MyAlerts even with Mention Me.

I tested on a new clean database and MyBB 1.8.8.

MyAlerts can be installed and uninstalled, but MentionMe never integrate MyAlerts, alert type never can be created even if i run uninstall and install again on Mention Me.

I run again uninstall Mention Me then MyAlerts and at this point i install MyAlerts and then Mention Me and same error appears, but MentionMe works fine, autocomplete and mentions.

[Image: 2cwlpg4.png]

I found this, inspectioning your files:

MentionMe/install.php

Line 413
	if (class_exists('MybbStuff_MyAlerts_AlertTypeManage')) {
Should be
if (class_exists('MybbStuff_MyAlerts_AlertTypeManager')) {

Missing r at the end

MentionMe/alerts.php

Line 17
define('MYALERTS_PLUGIN_PATH', MYBB_ROOT . 'inc/plugins/MyAlerts/');

Should be
define('MYALERTS_PLUGIN_PATH', MYBB_ROOT . 'inc/plugins/MybbStuff/');

MyAlerts was changed the path until 2.0.

I do not test it yet but i am on it, hope this helps...

Ok i forked now and review it i see you have been made some changes.

But this one is important

MentionMe/alerts.php

Line 17
Code:
define('MYALERTS_PLUGIN_PATH', MYBB_ROOT . 'inc/plugins/MyAlerts/');

Should be
Code:
define('MYALERTS_PLUGIN_PATH', MYBB_ROOT . 'inc/plugins/MybbStuff/');

Even i made some addittions to your new version as codename instead guid, and some lesser details i thik can be help.

See yah !!

Now all works fine Big Grin

I think was my mistake due i downloaded first sended files. About the first error...
The only infinite thing is the universe and human stupidity, but the universe is not for sure

Plugins 1.6.x

Plugins 1.8.x

(2016-12-10, 06:18 AM)Dark Neo Wrote: Nope MyAlerts can not be integrated.

[...]

MyAlerts can be installed and uninstalled, but MentionMe never integrate MyAlerts, alert type never can be created even if i run uninstall and install again on Mention Me.

[...]

I found this, inspectioning your files:

[...]

Now all works fine Big Grin

I think was my mistake due i downloaded first sended files. About the first error...

I think that you have it all straightened out, but if I am wrong, let me know.

(2016-12-10, 06:18 AM)Dark Neo Wrote: MentionMe/alerts.php

Line 17
define('MYALERTS_PLUGIN_PATH', MYBB_ROOT . 'inc/plugins/MyAlerts/');

Should be
define('MYALERTS_PLUGIN_PATH', MYBB_ROOT . 'inc/plugins/MybbStuff/');

MyAlerts was changed the path until 2.0.

I just committed a fix for that. Thanks for the report.

https://github.com/WildcardSearch/MentionMe/issues/90

(2016-12-10, 06:18 AM)Dark Neo Wrote: Even i made some addittions to your new version as codename instead guid, and some lesser details i thik can be help.

That's great. If you will make issues for the problems you find and handle them all in separate PRs

Thanks for all your help.
[retired]
Thank todo you, this is a great job, i am developing some things but i have some ideas todo contribute is the less that we can and have to do for plugins like this.

Thanks for your time and for all, we miss you buddy Wink
The only infinite thing is the universe and human stupidity, but the universe is not for sure

Plugins 1.6.x

Plugins 1.8.x

(2016-12-10, 09:11 PM)Dark Neo Wrote: Thank todo you, this is a great job, i am developing some things but i have some ideas todo contribute is the less that we can and have to do for plugins like this.

Thanks for your time and for all, we miss you buddy Wink

You're welcome. I really enjoy this work, I just wish I had more time in which to do it.
[retired]
How can I send an email notification to a user tagged using MentionMe?

E.G: I tag @UserName, email notification is sent to the email address in UserName's profile.
This version of the plugin is no longer supported. For the current version, click here:

[retired]


Forum Jump:


Users browsing this thread: 19 Guest(s)