[For 1.6] MentionMe 2.3.3 (for MyAlerts 1.05)

[bekircem]

I installed plugin but mention is dont work sometimes on my forum.

[Wildcard]

I installed plugin but mention is dont work sometimes on my forum.

The spelling of the username is important. It must be exactly the same username.

Give me a link to your forum and PM me a test account and I will check it out.

[Euan T]

One thing I have noticed after browsing your code is how the _is_installed() function works. Users can clear the admin log via the ACP so your current check could easily return false even when it is installed.

I never considered that.

Would it be better to use this?

function mention_is_installed ()
{
	global $cache, $plugins;
	
	$pluginlist = $cache->read("plugins");
	
	return in_array('mention', $pluginlist['active']);
}

EDIT:

No, that doesn't work correctly. I will keep trying.

The way you update user settings could also cause a timeout on boards with large amounts of users too. I still need to find a better way of handling settings so that's kind of my fault.

What is it that I am doing wrong?

Please let me know if there is a better way and I will implement the changes.

Thanks for all you help

1. I personally would check if the setting exists if it's added in install.

2. Imagine you have 100 users, that means you run 100 queries. 1000 users = 1000 queries etc. For boards with lots of users, you'll be running lots of queries which can take lots of time.

[Crayo]

Using this, works brilliantly compared to the other one we were using. Thanks.

[Wildcard]

1. I personally would check if the setting exists if it's added in install.

I have rewritten the installation routines and seperated the code into three files.

If MyAlerts is installed before MentionMe then is_installed (and the install/uninstall routines) get required once and the Admin will get Install & Activate.

If MyAlerts is not installed before MentionMe then the Admin will only see Activate.

If MyAlerts is installed after MentionMe, the 'Activate' will change to 'Install & Activate' and the Admin will need to click this before alerts will happen for mentions.

I am pushing the code to GitHub now and after a couple of days to test I will push to the mods site.

Please let me know if you feel this is a better solution and thanks for the advice.

EDIT: This is no longer true. The new feature advanced matching requires a setting and therefore I can just check for its existence as an _is_installed check.

2. Imagine you have 100 users, that means you run 100 queries. 1000 users = 1000 queries etc. For boards with lots of users, you'll be running lots of queries which can take lots of time.

I'm sorry but I am lost.

I thought you were saying the way that I added the checkbox to UCP was wrong somehow. Is that not what you meant?

EDIT: Nevermind you mean the way I am turning alerts on for mentions by default?

Using this, works brilliantly compared to the other one we were using. Thanks.

That is so awesome! I saw your status update earlier.

Thanks for the feedback man

[Banana Lord]

The dropdown doesn't seem to show properly on my forum:

[Wildcard]

The dropdown doesn't seem to show properly on my forum

That isn't an issue with MentionMe.

Take a look at the zindex settings used in your forum's theme.

[Banana Lord]

The dropdown doesn't seem to show properly on my forum

That isn't an issue with MentionMe.

Take a look at the zindex settings used in your forum's theme.

I hate to ask this but where specifically am I looking? I assume global.css and for the navbar's z-index setting?

[Wildcard]

Link me to your forum and I'll have a look.

[Tecca]

Just installed this over at TESOF. Thanks for making this plugin, it's great!