(2017-09-20, 10:19 PM)Lunorian Wrote: [ -> ] (2017-09-20, 08:22 PM)Shade Wrote: [ -> ] (2017-09-20, 06:51 PM)Lunorian Wrote: [ -> ]I already gave up on requesting you guys do faster testing and don't test obviously correct code, do what you want there. This is now about the "we're just volunteers" thing when people provide criticism.
What would you expect? I accept criticism on what I do, but absolutely not on when I should do something. Speaking about myself, who are you to request me to do something faster when I do what I can in my spare time? I study from 4 to 6 hours a day and other good 5 hours are spent working in a university hospital; I play ice hockey in the evening; and yet you come here and ask me to speed up my workflow? This is just unfair. This isn't a job, it's something I should enjoy doing when I feel like I have some time.
Oh, and there are people out there who think differently from you and can spot issues in your "obviously correct code" in a minute. Your last PR has been barely tested and yet you have been asked to edit it multiple times: I can't cite any better example. That's why we must test code, even patches coming from us are tested by other developers because what looks good to you doesn't mean it's good to others.
Remember what user devs said to former developer Nathan
Quote:Thats exactly what drives people away. Answers like the one above and general atitude of devs towards regular members. Its better you are out of team.....
That's what the community is concerned about. Developer Nathan who quit since he couldn't handle complaints,
Quote:The thread has reminded me why I left the team and why I won't be rejoining. The community is cancer. That's what drives people away. I feel stressed just thinking about it. If you want progress, be that progress. If you're going to come here to say the team is bad, the code is bad, the project is bad, everything is bad, apart from the way you're treating the people who volunteer their time and effort to maintain this project while dealing with your orange and everything else they're going through in life, eggplant off. /thread
said be that progress.
I saw an issue in MyBB, what did I do? I made a PR and fixed it. I could just create GitHub issues all day and let it be someone else's problem, but rather I took initiative and fixed it. The attitude of MyBB's dev team to normal members though is toxic to NORMAL PEOPLE who want to help either thru feedback or even developers willing to create PRs on GitHub and DO FREE FOR THE MYBB GROUP if you guys aren't careful the community support you guys have could one day go away and it'll just be a few devs working on MyBB, progress will be done even slower, and people will be forced to switch to other forum software. Now is the time to fix these community issues, not after your community starts to disappear.
You say what the "community is worried about" - but is that really true? You realise the MyBB project has had people who oppose every decision we have ever made because you simply can't please everyone. The job of the team is not to do what everyone says, because "everyone" rarely (if ever) agrees. The role of the team is to sift through suggestions and make the executive decision on what is actually a valuable suggestion. Most would agree that not testing PRs would be a bad plan, so we are not implementing that. A good example why would be
this. As the codebase doesn't have any kind of unit testing and because PHP versions can differ it really needs to be tested on multiple PHP versions.
Regarding your most recent PR lunorian, that is EXACTLY what we want, contribution. The PR has been under active discussion and is pretty much ready to be merged. That is what the project needs. People fixing things is always better than just reporting. But people fixing things properly is better than just submitting some untested fix.
This discussion really has gone far enough. We have taken your request into consideration and decided that untested PRs are not the best thing for the project, as is our role as guardians of the project. If you don't like that, then we're sorry about that, but we can't please everyone just for the sake of it. Decisions have been made even within the team that haven't received 100% agreement, such is life. Nevertheless, we always try to do what is best for the project, and if the majority of the community asks for something then yes it does hold more weight. This is essentially how we have done feature requests for the past decade.
This has, once again, descended into personal insults and attacks, and has gone far beyond the scope of the original post. So, once again, I'm going to request that it stops, for the final time - or I'll lock the thread. I've hesitated handing out any kind of warnings in the spirit of not appearing to "censor" anyone, but clearly that was a mistake.
So, in summary, yes this update is taking longer than expected, but it is coming. The final PRs are being merged now before we freeze the repo to test, package and distribute the update. If you want to write unit tests for the codebase, you are welcome to, but that is not a priority over fixing actual bugs in the codebase. Unit tests would indeed speed up a lot of testing of PRs but that is a mountain of work for a relatively small benefit, and many users would not see the benefit from it.
2.0 is coming, and development is slow, but also contributions have vastly decreased over the past few years, likely as a result of reducing market share. I work with a PHPBB team member and we have spoken about this extensively and he has mentioned the same is true for them. 2.0 will address issues like a lack of unit tests, and will hopefully be a lot less spaghetti code.