MyBB Community Forums

Full Version: MyBB-Tags
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18
Dear Sir, working fine Thanks.
(2014-10-02, 11:57 AM)My-BB.Ir Wrote: [ -> ]you can change it in the plugin file. Now tag size works with the thread views and max thread views.
For change the font-size of the Tags in "tags_box" template.
Is there a easy way to limit that size? Sorry my knowledge about Javascript is veeery low... I think it is working with a calculator which you can set somewhere. Something like "Threadviews * 1.2" for the size or am i completely wrong?
I have request that,

i need tags in following colors,

tag box = E0E0E0
tag text = 000000

also tag box's corner should be in same color E0E0E0

please help me to apply it.
(2014-10-21, 09:39 AM)cdusa8 Wrote: [ -> ]I have request that,

i need tags in following colors,

tag box = E0E0E0
tag text = 000000

also tag box's corner should be in same color E0E0E0

please help me to apply it.

You can change it in "Tags_box" template.
I have actually tested this and I have some suggestions.
  • Disallowed forums.
  • Filter by tags in forum display page.

Filtering in forum display could be more useful for some. Regarding your code:
  • Not really necessary.

    if(!function_exists('find_replace_templatesets'))

  • isset returns boolean itself, maybe just codign preferences:

    	if(isset($mybb->settings['tags_enabled']))
    	{
    		return true;
    	}

    Anyways, since you add DB tables you should rely on one instead of the settings.
  • $db->delete_query('settings', "name LIKE 'tags\_%'");

    Why not...

    $db->delete_query('settings', "gid={$gid}");
  • 	if($mybb->settings['tags_seo'])
    	{
    		define('TAG_URL', "tag-{name}.html");
    		define('TAG_URL_PAGE', "tag.html");
    	}
    	else
    	{
    		define('TAG_URL', "tag.php?name={name}");
    		define('TAG_URL_PAGE', "tag.php");
    	}

    Why not allowing custom URL schemes just like Google SEO does it? Unless I edit your code I can't use "etiqueta-{name}" or another.

    Instead of an yes/no option use two a text box setting.
  • Also, to be consistent you should use the design that MyBB uses in the PM Recipients field. Just IMO.

Cheers and looking forward to this.
(2014-10-23, 03:26 AM)Omar G. Wrote: [ -> ]I have actually tested this and I have some suggestions.
  • Disallowed forums.
  • Filter by tags in forum display page.

Filtering in forum display could be more useful for some. Regarding your code:
  • Not really necessary.

    if(!function_exists('find_replace_templatesets'))

  • isset returns boolean itself, maybe just codign preferences:

    	if(isset($mybb->settings['tags_enabled']))
    	{
    		return true;
    	}

    Anyways, since you add DB tables you should rely on one instead of the settings.
  • $db->delete_query('settings', "name LIKE 'tags\_%'");

    Why not...

    $db->delete_query('settings', "gid={$gid}");
  • 	if($mybb->settings['tags_seo'])
    	{
    		define('TAG_URL', "tag-{name}.html");
    		define('TAG_URL_PAGE', "tag.html");
    	}
    	else
    	{
    		define('TAG_URL', "tag.php?name={name}");
    		define('TAG_URL_PAGE', "tag.php");
    	}

    Why not allowing custom URL schemes just like Google SEO does it? Unless I edit your code I can't use "etiqueta-{name}" or another.

    Instead of an yes/no option use two a text box setting.
  • Also, to be consistent you should use the design that MyBB uses in the PM Recipients field. Just IMO.

Cheers and looking forward to this.

https://github.com/ATofighi/MyBB-Tags/issues/35
https://github.com/ATofighi/MyBB-Tags/issues/36
https://github.com/ATofighi/MyBB-Tags/issues/37
https://github.com/ATofighi/MyBB-Tags/issues/38
https://github.com/ATofighi/MyBB-Tags/issues/39

(2014-10-23, 03:26 AM)Omar G. Wrote: [ -> ][*]isset returns boolean itself, maybe just codign preferences:

	if(isset($mybb->settings['tags_enabled']))
	{
		return true;
	}
[*]

Hi,
I don't understand why it isn't good?
i am getting this error
MyBB has experienced an internal SQL error and cannot continue.

SQL Error:
1054 - Unknown column 'tag.name' in 'field list'
Query:
SELECT SUM(thread.views) as sumviews, tag.name from mybb_tags tag LEFT JOIN mybb_threads thread on(tag.tid = thread.tid) LEFT JOIN mybb_posts post on(thread.firstpost = post.pid) WHERE thread.tid > 0 And post.pid > 0 and thread.visible='1' AND thread.closed NOT LIKE 'moved|%' GROUP BY tag.hash ORDER BY RAND() LIMIT 0, 50
Please contact the MyBB Group for technical support.
(2014-10-26, 05:40 PM)helper4u Wrote: [ -> ]i am getting this error
MyBB has experienced an internal SQL error and cannot continue.

SQL Error:
1054 - Unknown column 'tag.name' in 'field list'
Query:
SELECT SUM(thread.views) as sumviews, tag.name from mybb_tags tag LEFT JOIN mybb_threads thread on(tag.tid = thread.tid) LEFT JOIN mybb_posts post on(thread.firstpost = post.pid) WHERE thread.tid > 0 And post.pid > 0 and thread.visible='1' AND thread.closed NOT LIKE 'moved|%' GROUP BY tag.hash ORDER BY RAND() LIMIT 0, 50
Please contact the MyBB Group for technical support.
Where you see this error?
What's your database engine and MyBB Version?
I am using mybb 1.8 and as soon as i activate the tag plugin, this error shows up.
(2014-10-26, 06:21 PM)helper4u Wrote: [ -> ]I am using mybb 1.8 and as soon as i activate the tag plugin, this error shows up.
Where do you see this Error? (index page? Tags page? forumdisplay? showthread?)
Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18