(2012-10-11, 09:54 PM)euantor Wrote: [ -> ]Fairly sure it's in the language file. I tried not to hardcode anything at all (except from a few of the error messages where I got lazy).
No, it's in the templates. It's not in the language file.
(2012-10-11, 11:24 AM)euantor Wrote: [ -> ]As tecca said, PHP does not need the closing tag. It's actually considered best not to include it unless you're mixing PHP and HTML in a single file.
Oh, ok. Good to know.
I just compared older file with newer one and wanted to mention it, in case it matters.
(2012-10-12, 05:00 AM)mybboardvietnam Wrote: [ -> ]Warning: cache error!?
It working a few minutes, then i can not access mybb.vn/community/Thread-MyBB-1-6-8.html?action=lastpost
but, dropping line ?action=lastpost, back to work??????
What was the full warning? This plugin shouldn't stop you from accessing anything.
(2012-10-12, 08:25 AM)loveley Wrote: [ -> ] (2012-10-11, 09:54 PM)euantor Wrote: [ -> ]Fairly sure it's in the language file. I tried not to hardcode anything at all (except from a few of the error messages where I got lazy).
No, it's in the templates. It's not in the language file.
(2012-10-11, 11:24 AM)euantor Wrote: [ -> ]As tecca said, PHP does not need the closing tag. It's actually considered best not to include it unless you're mixing PHP and HTML in a single file.
Oh, ok. Good to know. I just compared older file with newer one and wanted to mention it, in case it matters.
Darn. I'll have to fix that then for sure.
Ok, I'll push an update to the mods site and GitHub in a minute.
I have found the cause of the error cookie! "?action=lastpost" not work!
[
attachment=27448]
sorry about that! and thanks for support! ^^!
(2012-10-11, 08:26 AM)euantor Wrote: [ -> ]2. This is a known issue. I'm still trying to think of the best way to fix it. People complained about the old solution where alerts were marked read by opening the popup too.
Uh why? This is exactly how it works on Facebook -- this is exactly how people will expect it to work here.
Don't ask me Brad. I did it so they were marked as read as soon as you opened the popup and was told it wasn't a good way of doing it. I tried a few other ways too and each time there was always at least one person who complained about it >.>
My current plan is to mark them read when you click on them using a bit of JS.
But what if I want to ignore them? Maybe I don't want to click on every single one? Your original implementation was correct. People deriding it don't know what they're saying.
There will always be someone who complains. Who cares.
IMHO Euan the old way was good.