^ nice to see updated version from the original coder
(2015-03-27, 07:30 PM).m. Wrote: [ -> ]^ nice to see updated version from the original coder
Thank you! I'm just waiting for it to be approved on the mods site. I'm not sure if it's processing or not, though, as I don't see any sort of status or notification for it.
I can't see any project from you:
http://community.mybb.com/mods.php?actio...&uid=24043
BTW, it would be nice if by default (no tabs/fresh install) the plugin would build categories on a per category basis.
I don't want to manage tabs every time I add a new forum or move it to anotehr category, so taht would be nice IMO.
(2015-03-28, 05:33 AM)Omar G. Wrote: [ -> ]I can't see any project from you:
http://community.mybb.com/mods.php?actio...&uid=24043
BTW, it would be nice if by default (no tabs/fresh install) the plugin would build categories on a per category basis.
I don't want to manage tabs every time I add a new forum or move it to anotehr category, so taht would be nice IMO.
That's strange.. I created one and it never showed up, so I thought it might have just needed approval. I'll try to submit it again later.
I think it is visible to you even if it is not approved.
(2015-03-31, 02:17 PM)Hamster24 Wrote: [ -> ]getting error
http://community.mybb.com/mods.php?action=view&pid=456
You have selected an invalid project.
I checked and approved it now.
@EthanD
This query (used 2 times) is redundant and takes up server resources for no reason:
$query = $db->simple_select('users', 'default_tab', "`uid`='{$mybb->user['uid']}'");
since you can simply access that with already available $mybb->user array -
$mybb->user['default_tab']
And you're using $db->escape_string() incorrectly here:
eval("\$forums .= \"".$db->escape_string("<div id=\"tab_nav_{$current_iteration}\" style=\"{$display}\">".$setting['tab_list_html'])."</div>\";");
As the object and function name suggest, it's for escaping strings before using them in DB queries. Doing that on HTML output may end up in unexpected results. Not sure what's it's purpose here.
I love this plugin!
Thanks EthanD a lot!